[M] Change in dart/sdk[stable]: [stable][analyzer] Dot shorthands: Error when using type arguments on...
0 views
Skip to first unread message
Kallen Tu (Gerrit)
Nov 25, 2025, 5:06:00 PM (7 days ago) Nov 25
to Paul Berry, Leaf Petersen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Leaf Petersen and Paul Berry
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Leaf Petersen
- Paul Berry
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leaf Petersen (Gerrit)
Nov 25, 2025, 5:45:06 PM (7 days ago) Nov 25
to Kallen Tu, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu and Paul Berry
Leaf Petersen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kallen Tu
- Paul Berry
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Dec 1, 2025, 6:59:06 PM (22 hours ago) Dec 1
to Kallen Tu, Leaf Petersen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kallen Tu
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Dec 1, 2025, 7:01:45 PM (22 hours ago) Dec 1
to Paul Berry, Leaf Petersen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Kallen Tu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 1, 2025, 7:02:05 PM (22 hours ago) Dec 1
to Kallen Tu, Paul Berry, Leaf Petersen, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[stable][analyzer] Dot shorthands: Error when using type arguments on a factory constructor in an abstract class.
Fixing a small bug where we wouldn't check the other error cases if we
had an abstract class as the context type.
Added a few language tests and a unit test for this case.
Issue description: When attempting to use type arguments on a dot
shorthand constructor which is invoking a factory constructor in an
abstract class, the analyzer isn't reporting an error.
What is the fix: Change the code flow so that we are checking for type
arguments when resolving to a factory constructor in an abstract class.
Why cherry-pick: Users won't have a static error for this and will need
to compile in order to find that their code is incorrect.
Risk: Low, this fix has landed on the main channel and is tested with language tests and unit tests. Extra tests covering the changes with https://dart-review.googlesource.com/c/sdk/+/463466 and https://dart-review.googlesource.com/c/sdk/+/464764
Issue link(s): https://github.com/dart-lang/sdk/issues/61978
Change-Id: Ic36f3159f2cc6b1f87fe22e21f72a7124095019d
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/462542
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/463502
Commit-Queue: Kallen Tu <kall...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Leaf Petersen <le...@google.com>
Files:
- M CHANGELOG.md
- M pkg/analyzer/lib/src/dart/resolver/instance_creation_expression_resolver.dart
- M pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart
- A tests/language/dot_shorthands/constructor/constructor_abstract_class_error_test.dart
- A tests/language/dot_shorthands/constructor/constructor_abstract_class_test.dart
Change size: M
Delta: 5 files changed, 87 insertions(+), 9 deletions(-)
Branch: refs/heads/stable
Submit Requirements:
Cherry-Pick-Review: Code-Review+1 by Paul Berry, Code-Review+1 by Leaf Petersen
Code-Review: +1 by Paul Berry, +1 by Leaf Petersen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages