[M] Change in dart/sdk[main]: [dartdev] `dart run` progress updates to `stderr`

0 views
Skip to first unread message

Daco Harkes (Gerrit)

unread,
Mar 9, 2026, 2:49:59 AM (yesterday) Mar 9
to Ben Konyi, Commit Queue, rev...@dartlang.org
Attention needed from Ben Konyi

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd5caa65aab092341d370b09c016f89ae2a57987
Gerrit-Change-Number: 486203
Gerrit-PatchSet: 5
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 06:49:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ben Konyi (Gerrit)

unread,
Mar 9, 2026, 1:02:55 PM (14 hours ago) Mar 9
to Daco Harkes, Commit Queue, rev...@dartlang.org
Attention needed from Daco Harkes

Ben Konyi voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daco Harkes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd5caa65aab092341d370b09c016f89ae2a57987
Gerrit-Change-Number: 486203
Gerrit-PatchSet: 5
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Attention: Daco Harkes <dacoh...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 17:02:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daco Harkes (Gerrit)

unread,
Mar 9, 2026, 1:04:44 PM (14 hours ago) Mar 9
to Ben Konyi, Commit Queue, rev...@dartlang.org

Daco Harkes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd5caa65aab092341d370b09c016f89ae2a57987
Gerrit-Change-Number: 486203
Gerrit-PatchSet: 5
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 17:04:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 9, 2026, 2:05:32 PM (13 hours ago) Mar 9
to Daco Harkes, Ben Konyi, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[dartdev] `dart run` progress updates to `stderr`

Stream various updates from different components to `stderr` instead
of `stdout` on `dart run`.

TEST=pkg/dartdev/test/

Fixes: https://github.com/dart-lang/sdk/issues/62818
Change-Id: Icd5caa65aab092341d370b09c016f89ae2a57987
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Files:
  • M pkg/dart2native/lib/generate.dart
  • M pkg/dartdev/lib/src/commands/build.dart
  • M pkg/dartdev/lib/src/commands/compile.dart
  • M pkg/dartdev/lib/src/commands/install.dart
  • M pkg/dartdev/lib/src/commands/run.dart
  • M pkg/dartdev/lib/src/generate_kernel.dart
  • M pkg/dartdev/lib/src/native_assets.dart
  • M pkg/dartdev/lib/src/progress.dart
  • M pkg/dartdev/test/commands/compilation_server_test.dart
  • M pkg/dartdev/test/commands/run_test.dart
  • M pkg/dartdev/test/native_assets/run_remote_test.dart
  • M pkg/dartdev/test/native_assets/run_test.dart
  • M pkg/dartdev/test/utils.dart
Change size: M
Delta: 13 files changed, 146 insertions(+), 66 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ben Konyi
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd5caa65aab092341d370b09c016f89ae2a57987
Gerrit-Change-Number: 486203
Gerrit-PatchSet: 6
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages