[L] Change in dart/sdk[main]: [linter, DAS] Adds `simplify_variable_pattern` lint and fix
1 view
Skip to first unread message
Felipe Morschel (Gerrit)
Sep 18, 2025, 1:14:10 PMSep 18
to dart-analys...@google.com, rev...@dartlang.org
Felipe Morschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[linter, DAS] Adds `simplify_variable_pattern` lint and fix
Change-Id: Id02cc06a68c14bda578058e34050947253a888ee
Change information
Files:
- M pkg/analysis_server/lib/src/services/correction/assist.dart
- M pkg/analysis_server/lib/src/services/correction/assist_internal.dart
- A pkg/analysis_server/lib/src/services/correction/dart/remove_unnecessary_name.dart
- M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
- M pkg/analysis_server/lib/src/services/correction/fix.dart
- M pkg/analysis_server/lib/src/services/correction/fix_internal.dart
- A pkg/analysis_server/test/src/services/correction/assist/remove_unnecessary_name_test.dart
- A pkg/analysis_server/test/src/services/correction/fix/remove_unnecessary_name_test.dart
- M pkg/linter/lib/src/lint_codes.g.dart
- M pkg/linter/lib/src/lint_names.g.dart
- M pkg/linter/lib/src/rules.dart
- A pkg/linter/lib/src/rules/simplify_variable_pattern.dart
- M pkg/linter/messages.yaml
- M pkg/linter/test/rules/all.dart
- A pkg/linter/test/rules/simplify_variable_pattern_test.dart
Change size: L
Delta: 15 files changed, 535 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Nov 28, 2025, 10:37:36 PMNov 28
to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel
Samuel Rawlins voted and added 5 comments![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
5 comments
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved
I love this! Nice impl, and a long overdue lint rule.
File pkg/analysis_server/lib/src/services/correction/dart/remove_unnecessary_name.dart
Line 41, Patchset 1 (Latest):
DeclaredVariablePattern variablePattern;Samuel Rawlins . unresolved
This could be:
```
var pattern = node.pattern;
if (pattern is! DeclaredVariablePattern) return;
```
File pkg/linter/lib/src/rules/simplify_variable_pattern.dart
Line 43, Patchset 1 (Latest):
late AstNode node;Samuel Rawlins . unresolved
I might be crazy, but I can't see where this field is used.
Line 49, Patchset 1 (Latest):
DeclaredVariablePattern variablePattern;Samuel Rawlins . unresolved
I find these 6 lines a little round-about. We could just do:
```
var pattern = node.pattern;
if (pattern is! DeclaredVariablePattern) return;
```
Line 89, Patchset 1 (Latest):
String _accessor(PatternField field) => switch (field.parent) {Samuel Rawlins . unresolved
At some point I'm just playing code golf, apologies. But seeing all the cases that lead to 'field', I'm thinking this could just look like:
```
switch (field.parent) {
ObjectPattern(element: MethodElement()) => 'method',
ObjectPattern(element: GetterElement()) => 'getter',
_ => 'field',
};
```
Related details
Attention is currently required from:
- Brian Wilkerson
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Dec 10, 2025, 1:40:56 PM (11 days ago) Dec 10
to Felipe Morschel, Commit Queue, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Brian Wilkerson . resolved
This will need to be updated in order for it to be landed.
Related details
Attention is currently required from:
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 10, 2025, 2:14:26 PM (11 days ago) Dec 10
to Felipe Morschel, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
File pkg/linter/lib/src/diagnostic.g.dart
File-level comment, Patchset 2 (Latest):
Samuel Rawlins . unresolved
Hmm, hopefully the tools now generate the right file? Should you delete this and rerun... something? Paul has been doing a lot of refactor work here.
Related details
Attention is currently required from:
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Dec 10, 2025, 2:24:28 PM (11 days ago) Dec 10
to Commit Queue, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Felipe Morschel voted and added 5 comments![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
5 comments
File pkg/analysis_server/lib/src/services/correction/dart/remove_unnecessary_name.dart
This could be:
```
var pattern = node.pattern;
if (pattern is! DeclaredVariablePattern) return;
```
Samuel Rawlins . unresolved
Hmm, hopefully the tools now generate the right file? Should you delete this and rerun... something? Paul has been doing a lot of refactor work here.
Felipe Morschel
This was with the new tools. Although I've opened https://github.com/dart-lang/sdk/issues/62220.
Is there anything else I should do differently?
File pkg/linter/lib/src/rules/simplify_variable_pattern.dart
I might be crazy, but I can't see where this field is used.
Felipe Morschel
Oops! Probably left from my first tries hahaha. Thanks!
I find these 6 lines a little round-about. We could just do:
```
var pattern = node.pattern;
if (pattern is! DeclaredVariablePattern) return;
```
Felipe Morschel
Done
Line 89, Patchset 1:
String _accessor(PatternField field) => switch (field.parent) {Samuel Rawlins . resolved
At some point I'm just playing code golf, apologies. But seeing all the cases that lead to 'field', I'm thinking this could just look like:
```
switch (field.parent) {
ObjectPattern(element: MethodElement()) => 'method',
ObjectPattern(element: GetterElement()) => 'getter',
_ => 'field',
};
```
Felipe Morschel
Thanks for the suggestion! Not quite the syntax but it helped!
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 10, 2025, 2:58:31 PM (11 days ago) Dec 10
to Felipe Morschel, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
File pkg/linter/lib/src/diagnostic.g.dart
Felipe MorschelHmm, hopefully the tools now generate the right file? Should you delete this and rerun... something? Paul has been doing a lot of refactor work here.
This was with the new tools. Although I've opened https://github.com/dart-lang/sdk/issues/62220.
Is there anything else I should do differently?
Samuel Rawlins
Ah my bad. When I use Gerrit to compare Patchset 1 with Patchset 3, it says you added 4400 lines to diagnostic.g.dart, lol. But I see now what happened. All is good.
Related details
Attention is currently required from:
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 10, 2025, 2:59:12 PM (11 days ago) Dec 10
to Felipe Morschel, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Dec 10, 2025, 4:34:53 PM (11 days ago) Dec 10
to Samuel Rawlins, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3:
Felipe Morschel . resolved
Fixed the missing entries. Everything should pass now. Thanks for the bots!
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Dec 10, 2025, 4:46:37 PM (11 days ago) Dec 10
to Felipe Morschel, Samuel Rawlins, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
File pkg/linter/messages.yaml
Line 11324, Patchset 4 (Latest):
stable: "3.0"Brian Wilkerson . unresolved
I think this is supposed to be '3.11'.
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Dec 10, 2025, 4:47:16 PM (11 days ago) Dec 10
to Felipe Morschel, Connie Ooi, Samuel Rawlins, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Connie Ooi, Felipe Morschel and Samuel Rawlins
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Connie Ooi
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Dec 10, 2025, 4:55:31 PM (11 days ago) Dec 10
to Connie Ooi, Samuel Rawlins, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Connie Ooi and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
File pkg/linter/messages.yaml
Line 11324, Patchset 4 (Latest):
stable: "3.0"Brian Wilkerson . unresolved
I think this is supposed to be '3.11'.
Felipe Morschel
I forgot to change this now. I wasn't sure what version this would land. AFK now, I'll send a new patch later. Thanks!
Related details
Attention is currently required from:
- Brian Wilkerson
- Connie Ooi
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Dec 10, 2025, 5:41:26 PM (11 days ago) Dec 10
to Felipe Morschel, Brian Wilkerson, Connie Ooi, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Connie Ooi, Felipe Morschel and Samuel Rawlins
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
File pkg/linter/messages.yaml
Line 11324, Patchset 4 (Latest):
stable: "3.0"Brian Wilkerson . unresolved
Felipe MorschelI think this is supposed to be '3.11'.
I forgot to change this now. I wasn't sure what version this would land. AFK now, I'll send a new patch later. Thanks!
Brian Wilkerson
Lints always land, in some state, in the next release. We're currently at '3.11.0-edge', so the next release will be '3.11'.
Related details
Attention is currently required from:
- Connie Ooi
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Dec 10, 2025, 9:00:35 PM (11 days ago) Dec 10
to Brian Wilkerson, Connie Ooi, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Connie Ooi and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
File pkg/linter/messages.yaml
Felipe MorschelI think this is supposed to be '3.11'.
Brian WilkersonI forgot to change this now. I wasn't sure what version this would land. AFK now, I'll send a new patch later. Thanks!
Lints always land, in some state, in the next release. We're currently at '3.11.0-edge', so the next release will be '3.11'.
Attention is currently required from:
- Brian Wilkerson
- Connie Ooi
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 10, 2025, 9:40:57 PM (11 days ago) Dec 10
to Felipe Morschel, Brian Wilkerson, Connie Ooi, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Connie Ooi and Felipe Morschel
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Connie Ooi
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Dec 11, 2025, 2:14:56 PM (10 days ago) Dec 11
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, Connie Ooi, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Connie Ooi and Felipe Morschel
Brian Wilkerson voted![]( "Open in Gerrit")
Attention is currently required from:
- Connie Ooi
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 11, 2025, 2:15:14 PM (10 days ago) Dec 11
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, Connie Ooi, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[linter, DAS] Adds `simplify_variable_pattern` lint and fix
Change-Id: Id02cc06a68c14bda578058e34050947253a888ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450421
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/assist.dart
- M pkg/analysis_server/lib/src/services/correction/assist_internal.dart
- A pkg/analysis_server/lib/src/services/correction/dart/remove_unnecessary_name.dart
- M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
- M pkg/analysis_server/lib/src/services/correction/fix.dart
- M pkg/analysis_server/lib/src/services/correction/fix_internal.dart
- A pkg/analysis_server/test/src/services/correction/assist/remove_unnecessary_name_test.dart
- M pkg/analysis_server/test/src/services/correction/assist/test_all.dart
- A pkg/analysis_server/test/src/services/correction/fix/remove_unnecessary_name_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/test_all.dart
- M pkg/linter/example/all.yaml
- M pkg/linter/lib/src/diagnostic.g.dart
- M pkg/linter/lib/src/lint_names.g.dart
- M pkg/linter/lib/src/rules.dart
- A pkg/linter/lib/src/rules/simplify_variable_pattern.dart
- M pkg/linter/messages.yaml
- M pkg/linter/test/rules/all.dart
- A pkg/linter/test/rules/simplify_variable_pattern_test.dart
Change size: L
Delta: 18 files changed, 532 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connie Ooi (Gerrit)
Dec 17, 2025, 6:42:57 PM (4 days ago) Dec 17
to Felipe Morschel, Commit Queue, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Connie Ooi voted![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages