[S] Change in dart/sdk[main]: DAS: Use a shared mock in analytics_manager_test

0 views
Skip to first unread message

Samuel Rawlins (Gerrit)

unread,
Jan 9, 2026, 2:46:12 PM (2 days ago) Jan 9
to Keerti Parthasarathy, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy

Samuel Rawlins voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6de4772c83c97eb049edef101a41b36342bd5188
Gerrit-Change-Number: 471889
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 19:46:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
Jan 9, 2026, 3:30:17 PM (2 days ago) Jan 9
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Keerti Parthasarathy voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6de4772c83c97eb049edef101a41b36342bd5188
Gerrit-Change-Number: 471889
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 20:30:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Jan 9, 2026, 3:30:33 PM (2 days ago) Jan 9
to Samuel Rawlins, Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
DAS: Use a shared mock in analytics_manager_test
Change-Id: I6de4772c83c97eb049edef101a41b36342bd5188
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Auto-Submit: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Files:
  • M pkg/analysis_server/test/src/analytics/analytics_manager_test.dart
Change size: S
Delta: 1 file changed, 3 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keerti Parthasarathy
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6de4772c83c97eb049edef101a41b36342bd5188
Gerrit-Change-Number: 471889
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages