[L] Change in dart/sdk[main]: [test_runner] Show hidden flags in `--help` with `--verbose`
0 views
Skip to first unread message
Ömer Ağacan (Gerrit)
Dec 22, 2025, 5:05:15 AM (3 days ago) Dec 22
to Alexander Thomas, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Thomas
Ömer Ağacan added 1 comment![]( "Open in Gerrit")
File pkg/test_runner/lib/src/options.dart
Line 589, Patchset 1 (Latest):
print(_createParser(verbose: verbose).usage);Ömer Ağacan . resolved
When `verbose` is `false` we could use the same parser used for parsing (`_parser`). I don't think it'll matter for performance (this code only runs with `--help`), and the current code may be a bit easier to maintain as it doesn't depend on the `verbose` argument passed to `_createParser` in `_parser`.
Related details
Attention is currently required from:
- Alexander Thomas
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Thomas (Gerrit)
Dec 22, 2025, 6:53:55 AM (3 days ago) Dec 22
to Ömer Ağacan, Commit Queue, rev...@dartlang.org
Attention needed from Ömer Ağacan
Alexander Thomas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Thomas
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Ömer Ağacan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ömer Ağacan (Gerrit)
Dec 22, 2025, 6:54:09 AM (3 days ago) Dec 22
to Alexander Thomas, Commit Queue, rev...@dartlang.org
Ömer Ağacan voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 22, 2025, 6:54:24 AM (3 days ago) Dec 22
to Ömer Ağacan, Alexander Thomas, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[test_runner] Show hidden flags in `--help` with `--verbose`
Change-Id: I0d05ed057a80bad24fc43372236a24ac8c500026
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469440
Reviewed-by: Alexander Thomas <at...@google.com>
Commit-Queue: Ömer Ağacan <ome...@google.com>
Files:
- M pkg/test_runner/lib/src/options.dart
Change size: L
Delta: 1 file changed, 309 insertions(+), 305 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Thomas
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages