[S] Change in dart/sdk[main]: [pkg/wasm_builder, pkg/dart2wasm] Enable primary constructors.

0 views
Skip to first unread message

Stephen Adams (Gerrit)

unread,
Aug 4, 2026, 6:22:34 PM (2 days ago) Aug 4
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org

Stephen Adams voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iabdea36fb4088fadbbc1583d8a913ed8c07c3b09
Gerrit-Change-Number: 531320
Gerrit-PatchSet: 3
Gerrit-Owner: Stephen Adams <s...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Stephen Adams <s...@google.com>
Gerrit-Comment-Date: Tue, 04 Aug 2026 22:22:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Stephen Adams (Gerrit)

unread,
Aug 5, 2026, 8:02:58 PM (8 hours ago) Aug 5
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org

Stephen Adams submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[pkg/wasm_builder, pkg/dart2wasm] Enable primary constructors.

Enabled 3.13 exactly how it is enabled in a dozen or so other `pkg/`
packages.

Changed one file in each package to ensure the feature is working.
Change-Id: Iabdea36fb4088fadbbc1583d8a913ed8c07c3b09
Reviewed-by: Nate Biggs <nate...@google.com>
Files:
  • M pkg/dart2wasm/lib/wasm_annotations.dart
  • M pkg/dart2wasm/pubspec.yaml
  • M pkg/wasm_builder/lib/source_map.dart
  • M pkg/wasm_builder/pubspec.yaml
Change size: S
Delta: 4 files changed, 8 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Biggs
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iabdea36fb4088fadbbc1583d8a913ed8c07c3b09
Gerrit-Change-Number: 531320
Gerrit-PatchSet: 5
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages