[M] Change in dart/sdk[main]: Code cleanup in log player and server driver
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Nov 26, 2025, 6:39:20 PM (3 days ago) Nov 26
to Brian Wilkerson, Keerti Parthasarathy, Jake Macdonald, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Jake Macdonald and Keerti Parthasarathy
Brian Wilkerson voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jake Macdonald
- Keerti Parthasarathy
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
Nov 26, 2025, 7:35:48 PM (3 days ago) Nov 26
to Brian Wilkerson, Jake Macdonald, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Jake Macdonald
Keerti Parthasarathy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Keerti Parthasarathy
| Code-Review | +1 |
1 comment
File pkg/analysis_server/tool/log_player/server_driver.dart
Line 18, Patchset 1 (Latest):
/// A list of arguments from the comman-line used to start the server.Keerti Parthasarathy . unresolved
nit: typo
Related details
Attention is currently required from:
- Brian Wilkerson
- Jake Macdonald
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Nov 27, 2025, 10:04:24 AM (2 days ago) Nov 27
to Brian Wilkerson, Keerti Parthasarathy, Jake Macdonald, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Jake Macdonald
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Commit-Queue | +2 |
1 comment
File pkg/analysis_server/tool/log_player/server_driver.dart
Line 18, Patchset 1:
/// A list of arguments from the comman-line used to start the server.Keerti Parthasarathy . resolved
Brian Wilkersonnit: typo
Done
Related details
Attention is currently required from:
- Jake Macdonald
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Nov 27, 2025, 10:29:45 AM (2 days ago) Nov 27
to Brian Wilkerson, Keerti Parthasarathy, Jake Macdonald, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analysis_server/tool/log_player/server_driver.dart
Insertions: 1, Deletions: 1.
@@ -15,7 +15,7 @@
/// The protocol being used by the server.
final ServerProtocol _protocol;
- /// A list of arguments from the comman-line used to start the server.
+ /// A list of arguments from the command-line used to start the server.
final List<String> arguments;
/// The sink used to send messages from the IDE to the server's stdin, or
```
Change information
Commit message:
Code cleanup in log player and server driver
Setting the command-line arguments separately from the protocol used to
be necessary, but it no long is, so it's cleaner to just set the command
line arguments when creating the server and moving the handling of the
protocol option into the server. This resulted in a cleaner API and
implementation.
Change-Id: I9456e2a43310bb855b54c010af64ce0328a08ff7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464785
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Files:
- M pkg/analysis_server/tool/log_player/log_player.dart
- M pkg/analysis_server/tool/log_player/server_driver.dart
Change size: M
Delta: 2 files changed, 33 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Keerti Parthasarathy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages