[M] Change in dart/sdk[main]: DAS: Simplify the storage of the fix mappings for assists
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Mar 14, 2025, 11:46:03 AMMar 14
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Mar 14, 2025, 1:48:24 PMMar 14
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 14, 2025, 1:48:39 PMMar 14
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
DAS: Simplify the storage of the fix mappings for assists
This map is a map of _assists_ and the lint rules that can _fix_, when
used as a _fix_ producer. A rather specific set of information. It was
being passed around everywhere, but now with the instance of
`_RegisteredAssistGenerators` to hang onto, we can leave the map there,
and remove it from a handful of other classes which all ultimately just
passed the map back to AssistProcessor.
Change-Id: Ib2aa4ea1fdb23bbaf55b3377232f2205b7f91447
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415460
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart
- M pkg/analysis_server/lib/src/analysis_server.dart
- M pkg/analysis_server/lib/src/cider/assists.dart
- M pkg/analysis_server/lib/src/handler/legacy/edit_get_assists.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart
- M pkg/analysis_server/lib/src/services/correction/assist.dart
- M pkg/analysis_server/lib/src/services/correction/assist_generators.dart
- M pkg/analysis_server/lib/src/services/correction/assist_internal.dart
- M pkg/analysis_server/test/src/cider/assists_test.dart
- M pkg/analysis_server/test/src/services/correction/assist/assist_processor.dart
Change size: M
Delta: 10 files changed, 19 insertions(+), 66 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages