[M] Change in dart/sdk[main]: Update the prefer-initializing-formals lint for primary constructors
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
4:02 PM (5 hours ago) 4:02 PM
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
4:24 PM (4 hours ago) 4:24 PM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
File pkg/linter/test/rule_test_support.dart
Line 32, Patchset 2 (Latest):
Future<void> assertDiagnosticsFromMarkdown(String content) {Samuel Rawlins . unresolved
It would be nice to have a doc comment explaining the markdown syntax.
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
5:15 PM (3 hours ago) 5:15 PM
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Commit-Queue | +2 |
1 comment
File pkg/linter/test/rule_test_support.dart
Line 32, Patchset 2:
Future<void> assertDiagnosticsFromMarkdown(String content) {Samuel Rawlins . resolved
It would be nice to have a doc comment explaining the markdown syntax.
Brian Wilkerson
I mean, who documents test code. :-/
Seriously, though, I added a comment pointing to the documentation of the markdown syntax.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
5:18 PM (3 hours ago) 5:18 PM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
File pkg/linter/test/rule_test_support.dart
Line 32, Patchset 2:
Future<void> assertDiagnosticsFromMarkdown(String content) {Samuel Rawlins . resolved
Brian WilkersonIt would be nice to have a doc comment explaining the markdown syntax.
I mean, who documents test code. :-/
Seriously, though, I added a comment pointing to the documentation of the markdown syntax.
Samuel Rawlins
Haha, perfect. I figured there was existing documentation somewhere. Thanks for putting the pointer in there.
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
5:53 PM (3 hours ago) 5:53 PM
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update the prefer-initializing-formals lint for primary constructors
I got tired of trying to compute diagnostic locations, so I also added
a utility method that will use our standard markdown format. I tried
just modifying the existing `assertDiagnostics` method, but there are
a few tests that include text that `TestCode` parses as markdown.
Closes https://github.com/dart-lang/sdk/issues/62023
Change-Id: Iccc410cc4036c299d0cb000f1d1642ddef63e98a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491703
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/linter/lib/src/rules/prefer_initializing_formals.dart
- M pkg/linter/test/rule_test_support.dart
- M pkg/linter/test/rules/prefer_initializing_formals_test.dart
Change size: M
Delta: 3 files changed, 123 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages