[XS] Change in dart/sdk[main]: [tests] Skip debugger test for AOT runtime

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Oct 30, 2025, 11:25:25 AM (4 days ago) Oct 30
to Alexander Markov, Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Aprelev

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Aprelev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1f7b9ac12ae8412fceb6da8072eb36024790af5e
Gerrit-Change-Number: 458620
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Alexander Aprelev <a...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 15:25:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Aprelev (Gerrit)

unread,
Oct 30, 2025, 1:53:02 PM (4 days ago) Oct 30
to Alexander Markov, Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov

Alexander Aprelev voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1f7b9ac12ae8412fceb6da8072eb36024790af5e
Gerrit-Change-Number: 458620
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 17:52:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
Oct 30, 2025, 2:07:39 PM (4 days ago) Oct 30
to Alexander Markov, Alexander Aprelev, Commit Queue, rev...@dartlang.org

Alexander Markov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1f7b9ac12ae8412fceb6da8072eb36024790af5e
Gerrit-Change-Number: 458620
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 18:07:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Oct 30, 2025, 2:07:58 PM (4 days ago) Oct 30
to Alexander Markov, Alexander Aprelev, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[tests] Skip debugger test for AOT runtime

It is not enough to test if "$compiler == dartkp" to filter test in
AOT mode as "$runtime == dart_precompiled" can be also used with
"$compiler == dart2bytecode" (e.g. on vm-aot-dyn-linux-product-x64).
Change-Id: I1f7b9ac12ae8412fceb6da8072eb36024790af5e
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
  • M tests/co19/co19-kernel.status
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alexander Aprelev
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1f7b9ac12ae8412fceb6da8072eb36024790af5e
Gerrit-Change-Number: 458620
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages