[XL] Change in dart/sdk[main]: Breaking changes for analyzer 13.0.0

2 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Mar 27, 2026, 11:58:51 AMMar 27
to Johnni Winther, Brian Wilkerson, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Johnni Winther and Paul Berry

Konstantin Shcheglov added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Johnni Winther
  • Paul Berry
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
Gerrit-Change-Number: 488624
Gerrit-PatchSet: 17
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 27 Mar 2026 15:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Mar 27, 2026, 12:31:23 PMMar 27
to Konstantin Shcheglov, Brian Wilkerson, Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review+1

1 comment

Patchset-level comments
Brian Wilkerson . resolved

The analysis_server, analyzer_plugin, linter, and API changes lgtm.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
    Gerrit-Change-Number: 488624
    Gerrit-PatchSet: 17
    Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Comment-Date: Fri, 27 Mar 2026 16:31:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Apr 7, 2026, 1:31:18 PMApr 7
    to Brian Wilkerson, Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson, Johnni Winther and Paul Berry

    Konstantin Shcheglov added 1 comment

    Patchset-level comments
    File-level comment, Patchset 27 (Latest):
    Konstantin Shcheglov . resolved

    PTAL at the latest changes.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Johnni Winther
    • Paul Berry
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
      Gerrit-Change-Number: 488624
      Gerrit-PatchSet: 27
      Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Reviewer: Paul Berry <paul...@google.com>
      Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
      Gerrit-Attention: Paul Berry <paul...@google.com>
      Gerrit-Attention: Johnni Winther <johnni...@google.com>
      Gerrit-Comment-Date: Tue, 07 Apr 2026 17:31:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      open
      diffy

      Johnni Winther (Gerrit)

      unread,
      Apr 8, 2026, 6:06:41 AMApr 8
      to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
      Attention needed from Brian Wilkerson, Konstantin Shcheglov and Paul Berry

      Johnni Winther voted and added 13 comments

      Votes added by Johnni Winther

      Code-Review+1

      13 comments

      File pkg/analyzer/api.txt
      Line 2854, Patchset 27 (Latest): visitNamedExpression (method: R? Function(NamedExpression))
      Johnni Winther . unresolved

      Something seems to be missing in this file; it only contains changes related to formal parameters and not for instance changes to arguments.

      File pkg/analyzer/lib/dart/ast/visitor.g.dart
      Line 131, Patchset 27 (Parent): R? visitCollectionElement(CollectionElement node) => visitNode(node);

      R? visitCombinator(Combinator node) => visitNode(node);
      Johnni Winther . unresolved

      Was this change intended?

      File pkg/analyzer/lib/src/dart/ast/ast.dart
      Line 1049, Patchset 27 (Latest):/// arguments ::=
      /// [NamedArgument] (',' [NamedArgument])*
      /// | [Expression] (',' [Expression])* (',' [NamedArgument])*
      @AnalyzerPublicApi(message: 'exported by lib/dart/ast/ast.dart')
      Johnni Winther . unresolved

      This seems to be the old grammar from before named-arguments-anywhere.

      Line 4844, Patchset 27 (Latest):base mixin CollectionElementImpl on AstNodeImpl implements CollectionElement {
      Johnni Winther . unresolved

      This change doesn't seem to be related to any for mentioned changes (and like the cause of the change to the visitor).

      Line 17564, Patchset 27 (Latest):/// A label on either a [LabeledStatement] or a deprecated named argument shape.
      Johnni Winther . unresolved

      Remove this?

      File pkg/analyzer/lib/src/dart/resolver/element_binding_visitor.dart
      Line 302, Patchset 27 (Latest): var functionTypedSuffix = node.functionTypedSuffix;
      if (functionTypedSuffix != null) {
      var holder = ElementHolder(fragment);
      _withElementHolder(holder, () {
      _withElementWalker(
      _elementWalker != null ? ElementWalker.forParameter(fragment) : null,
      () {
      node.metadata.accept(this);
      node.documentationComment?.accept(this);
      node.type?.accept(this);
      functionTypedSuffix.typeParameters?.accept(this);
      functionTypedSuffix.formalParameters.accept(this);
      },
      );
      });
      if (_elementWalker == null) {
      fragment.typeParameters = holder.typeParameters;
      fragment.formalParameters = holder.formalParameters;
      }
      } else {
      node.metadata.accept(this);
      node.documentationComment?.accept(this);
      node.type?.accept(this);
      }

      _visitFormalParameterDefaultValue(node);
      Johnni Winther . unresolved

      Could we share this between the handling of the different formal parameters?

      File pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
      Line 815, Patchset 27 (Latest): void visitShowCombinator(ShowCombinator node) {
      var scope = nameScope.tryCast<LibraryFragmentScope>();
      scope?.importsTrackingActive(false);
      try {
      super.visitShowCombinator(node);
      } finally {
      scope?.importsTrackingActive(true);
      }
      }
      Johnni Winther . unresolved

      This change seem unrelated.

      File pkg/analyzer/lib/src/dart/resolver/typed_literal_resolver.dart
      Line 260, Patchset 27 (Latest): return _typeProvider.dynamicType;
      Johnni Winther . unresolved

      I guess this was triggered by the change to the `CollectionElementImpl` hierarchy. Should we handle `CollectionElementImpl` explicitly instead?

      Line 468, Patchset 27 (Latest): return _InferredCollectionElementTypeInformation();
      Johnni Winther . unresolved

      Ditto.

      File pkg/analyzer/lib/src/error/best_practices_verifier.dart
      Line 711, Patchset 27 (Latest): void visitNamedArgument(NamedArgument node) {
      _invalidAccessVerifier.verifyNamedArgument(node);
      super.visitNamedArgument(node);
      }
      Johnni Winther . unresolved

      Is this new functionality? (I don't see any previous code for `NamedExpression`)

      File pkg/analyzer/lib/src/error/error_handler_verifier.dart
      Line 202, Patchset 27 (Latest): AstNode errorNode,
      Expression expression,
      Johnni Winther . unresolved

      Not for this CL: We should use named parameters for these. Call-sites are confusing.

      File pkg/analyzer/lib/src/generated/error_verifier.dart
      Line 246, Patchset 27 (Latest): /// This is set to `true` iff the visitor is currently within a function typed
      /// formal parameter.
      /// A flag indicating whether the visitor is currently within code in the SDK.
      Johnni Winther . unresolved

      Remove?

      File pkg/analyzer/lib/src/generated/resolver.dart
      Line 4762, Patchset 27 (Latest): case ExtensionOverride(argumentList: ArgumentListImpl(arguments: [_])):
      case _:
      ExpressionImpl shortingTarget = switch (target) {
      ExtensionOverride(:var argumentList) =>
      argumentList.arguments[0].argumentExpression as ExpressionImpl,
      _ => target,
      };
      flow.storeExpressionInfo(
      Johnni Winther . unresolved

      I think this can be written as

          case ExtensionOverride(argumentList: 
                  ArgumentListImpl(arguments: [
                     ArgumentImpl(argumentExpression: var expression)
                  ]))):
          case var expression:
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Brian Wilkerson
      • Konstantin Shcheglov
      • Paul Berry
      Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
        Gerrit-Change-Number: 488624
        Gerrit-PatchSet: 27
        Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
        Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Paul Berry <paul...@google.com>
        Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Attention: Paul Berry <paul...@google.com>
        Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Comment-Date: Wed, 08 Apr 2026 10:06:35 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Konstantin Shcheglov (Gerrit)

        unread,
        Apr 8, 2026, 1:15:33 PM (14 days ago) Apr 8
        to Johnni Winther, Brian Wilkerson, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
        Attention needed from Brian Wilkerson and Paul Berry

        Konstantin Shcheglov added 13 comments

        File pkg/analyzer/api.txt
        Line 2854, Patchset 27: visitNamedExpression (method: R? Function(NamedExpression))
        Johnni Winther . resolved

        Something seems to be missing in this file; it only contains changes related to formal parameters and not for instance changes to arguments.

        Konstantin Shcheglov

        Indeed, because it was impossible to run bots at all, I forgot to regenerate.
        Fixed.

        File pkg/analyzer/lib/dart/ast/visitor.g.dart
        Line 131, Patchset 27 (Parent): R? visitCollectionElement(CollectionElement node) => visitNode(node);

        R? visitCombinator(Combinator node) => visitNode(node);
        Johnni Winther . resolved

        Was this change intended?

        Konstantin Shcheglov

        Yes, see https://github.com/dart-lang/sdk/issues/62944 "5. Syntactic Types and Contextual Roles"

        File pkg/analyzer/lib/src/dart/ast/ast.dart
        Line 1049, Patchset 27:/// arguments ::=

        /// [NamedArgument] (',' [NamedArgument])*
        /// | [Expression] (',' [Expression])* (',' [NamedArgument])*
        @AnalyzerPublicApi(message: 'exported by lib/dart/ast/ast.dart')
        Johnni Winther . resolved

        This seems to be the old grammar from before named-arguments-anywhere.

        Konstantin Shcheglov

        Done

        Line 4844, Patchset 27:base mixin CollectionElementImpl on AstNodeImpl implements CollectionElement {
        Johnni Winther . resolved

        This change doesn't seem to be related to any for mentioned changes (and like the cause of the change to the visitor).

        Konstantin Shcheglov

        See https://github.com/dart-lang/sdk/issues/62944 "5. Syntactic Types and Contextual Roles". It is actually intentional.

        Line 17564, Patchset 27:/// A label on either a [LabeledStatement] or a deprecated named argument shape.
        Johnni Winther . resolved

        Remove this?

        Konstantin Shcheglov

        Done

        File pkg/analyzer/lib/src/dart/resolver/element_binding_visitor.dart
        Line 302, Patchset 27: var functionTypedSuffix = node.functionTypedSuffix;

        if (functionTypedSuffix != null) {
        var holder = ElementHolder(fragment);
        _withElementHolder(holder, () {
        _withElementWalker(
        _elementWalker != null ? ElementWalker.forParameter(fragment) : null,
        () {
        node.metadata.accept(this);
        node.documentationComment?.accept(this);
        node.type?.accept(this);
        functionTypedSuffix.typeParameters?.accept(this);
        functionTypedSuffix.formalParameters.accept(this);
        },
        );
        });
        if (_elementWalker == null) {
        fragment.typeParameters = holder.typeParameters;
        fragment.formalParameters = holder.formalParameters;
        }
        } else {
        node.metadata.accept(this);
        node.documentationComment?.accept(this);
        node.type?.accept(this);
        }

        _visitFormalParameterDefaultValue(node);
        Johnni Winther . resolved

        Could we share this between the handling of the different formal parameters?

        Konstantin Shcheglov

        Hm...
        I'm almost sure that you made this same comment the previous review round.
        And I remember doing it too.
        But apparently it did not go into the result.
        Sorry about this. Done now.

        File pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
        Line 815, Patchset 27: void visitShowCombinator(ShowCombinator node) {

        var scope = nameScope.tryCast<LibraryFragmentScope>();
        scope?.importsTrackingActive(false);
        try {
        super.visitShowCombinator(node);
        } finally {
        scope?.importsTrackingActive(true);
        }
        }
        Johnni Winther . resolved

        This change seem unrelated.

        Konstantin Shcheglov

        It just sorted after `visitRegularFormalParameter` now, see left panel line 812.

        File pkg/analyzer/lib/src/dart/resolver/typed_literal_resolver.dart
        Line 260, Patchset 27: return _typeProvider.dynamicType;
        Johnni Winther . resolved

        I guess this was triggered by the change to the `CollectionElementImpl` hierarchy. Should we handle `CollectionElementImpl` explicitly instead?

        Konstantin Shcheglov

        Yes, the problem is that `CollectionElementImpl` is not a sealed class anymore, it is not a class at all:
        ```


        base mixin CollectionElementImpl on AstNodeImpl implements CollectionElement {}

        ```

        So, we cannot do exhaustive switch on it.
        I will make it more explicit by adding default-throw.

        Line 468, Patchset 27: return _InferredCollectionElementTypeInformation();
        Johnni Winther . resolved

        Ditto.

        Konstantin Shcheglov

        Done

        File pkg/analyzer/lib/src/error/best_practices_verifier.dart
        Line 711, Patchset 27: void visitNamedArgument(NamedArgument node) {
        _invalidAccessVerifier.verifyNamedArgument(node);
        super.visitNamedArgument(node);
        }
        Johnni Winther . resolved

        Is this new functionality? (I don't see any previous code for `NamedExpression`)

        Konstantin Shcheglov

        No, this is not a new functionality. Previously we used `NamedExpression` that had `Label`, which was a wrapper around `SimpleIdentifier`. So, we would check through it. This is a wrong model, but it duck-fitted into the check. As we fix the model, we make checks explicit.

        File pkg/analyzer/lib/src/error/error_handler_verifier.dart
        Line 202, Patchset 27: AstNode errorNode,
        Expression expression,
        Johnni Winther . resolved

        Not for this CL: We should use named parameters for these. Call-sites are confusing.

        Konstantin Shcheglov

        Acknowledged

        File pkg/analyzer/lib/src/generated/error_verifier.dart
        Line 246, Patchset 27: /// This is set to `true` iff the visitor is currently within a function typed

        /// formal parameter.
        /// A flag indicating whether the visitor is currently within code in the SDK.
        Johnni Winther . resolved

        Remove?

        Konstantin Shcheglov

        Done

        File pkg/analyzer/lib/src/generated/resolver.dart
        Line 4762, Patchset 27: case ExtensionOverride(argumentList: ArgumentListImpl(arguments: [_])):

        case _:
        ExpressionImpl shortingTarget = switch (target) {
        ExtensionOverride(:var argumentList) =>
        argumentList.arguments[0].argumentExpression as ExpressionImpl,
        _ => target,
        };
        flow.storeExpressionInfo(
        Johnni Winther . resolved

        I think this can be written as

            case ExtensionOverride(argumentList: 
                    ArgumentListImpl(arguments: [
                       ArgumentImpl(argumentExpression: var expression)
                    ]))):
            case var expression:
        Konstantin Shcheglov

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Brian Wilkerson
        • Paul Berry
        Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
        Gerrit-Change-Number: 488624
        Gerrit-PatchSet: 28
        Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
        Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Paul Berry <paul...@google.com>
        Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Attention: Paul Berry <paul...@google.com>
        Gerrit-Comment-Date: Wed, 08 Apr 2026 17:15:29 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Brian Wilkerson (Gerrit)

        unread,
        Apr 9, 2026, 12:29:50 PM (13 days ago) Apr 9
        to Konstantin Shcheglov, Brian Wilkerson, Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
        Attention needed from Konstantin Shcheglov and Paul Berry

        Brian Wilkerson voted and added 3 comments

        Votes added by Brian Wilkerson

        Code-Review+1

        3 comments

        Patchset-level comments
        File-level comment, Patchset 28 (Latest):
        Brian Wilkerson . resolved

        I can't be sure that I've verified all of the changes. There are just too many of them for me to have confidence that I didn't miss something. But I've done my best to do more than just a spot check, and we'll have to hope that the tests are adequate.

        File pkg/analysis_server/lib/src/computer/computer_document_highlights.dart
        Line 336, Patchset 27: void visitNamedArgument(NamedArgument node) {
        Brian Wilkerson . unresolved

        It seems odd that this isn't replacing some existing code. Is this new behavior?

        File pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart
        Line 225, Patchset 27: node.argumentExpression.accept(this);
        Brian Wilkerson . unresolved

        It seems like it would be both more future proof and more consistent for this to just invoke `super.visitNamedArgument(node);`.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Konstantin Shcheglov
        • Paul Berry
        Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
        Gerrit-Change-Number: 488624
        Gerrit-PatchSet: 28
        Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
        Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Paul Berry <paul...@google.com>
        Gerrit-Attention: Paul Berry <paul...@google.com>
        Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Comment-Date: Thu, 09 Apr 2026 16:29:45 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Konstantin Shcheglov (Gerrit)

        unread,
        Apr 9, 2026, 2:01:03 PM (13 days ago) Apr 9
        to Brian Wilkerson, Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
        Attention needed from Brian Wilkerson, Johnni Winther and Paul Berry

        Konstantin Shcheglov added 2 comments

        File pkg/analysis_server/lib/src/computer/computer_document_highlights.dart
        Line 336, Patchset 27: void visitNamedArgument(NamedArgument node) {
        Brian Wilkerson . resolved

        It seems odd that this isn't replacing some existing code. Is this new behavior?

        Konstantin Shcheglov

        Previously we were doing this in `visitSimpleIdentifier`

        File pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart
        Line 225, Patchset 27: node.argumentExpression.accept(this);
        Brian Wilkerson . resolved

        It seems like it would be both more future proof and more consistent for this to just invoke `super.visitNamedArgument(node);`.

        Konstantin Shcheglov

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Brian Wilkerson
        • Johnni Winther
        • Paul Berry
        Submit Requirements:
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: sdk
          Gerrit-Branch: main
          Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
          Gerrit-Change-Number: 488624
          Gerrit-PatchSet: 30
          Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
          Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
          Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
          Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
          Gerrit-Reviewer: Paul Berry <paul...@google.com>
          Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
          Gerrit-Attention: Paul Berry <paul...@google.com>
          Gerrit-Attention: Johnni Winther <johnni...@google.com>
          Gerrit-Comment-Date: Thu, 09 Apr 2026 18:00:59 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
          unsatisfied_requirement
          open
          diffy

          Brian Wilkerson (Gerrit)

          unread,
          Apr 17, 2026, 12:16:21 PM (5 days ago) Apr 17
          to Konstantin Shcheglov, Brian Wilkerson, Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
          Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry

          Brian Wilkerson voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Johnni Winther
          • Konstantin Shcheglov
          • Paul Berry
          Submit Requirements:
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 40
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-Attention: Paul Berry <paul...@google.com>
            Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Attention: Johnni Winther <johnni...@google.com>
            Gerrit-Comment-Date: Fri, 17 Apr 2026 16:16:16 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Paul Berry (Gerrit)

            unread,
            Apr 17, 2026, 1:46:18 PM (5 days ago) Apr 17
            to Konstantin Shcheglov, Brian Wilkerson, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
            Attention needed from Johnni Winther and Konstantin Shcheglov

            Paul Berry voted and added 1 comment

            Votes added by Paul Berry

            Code-Review+1

            1 comment

            Patchset-level comments
            File-level comment, Patchset 40 (Latest):
            Paul Berry . resolved

            Changes in tests/language lgtm.

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Johnni Winther
            • Konstantin Shcheglov
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 40
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Attention: Johnni Winther <johnni...@google.com>
            Gerrit-Comment-Date: Fri, 17 Apr 2026 17:46:11 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Brian Wilkerson (Gerrit)

            unread,
            Apr 17, 2026, 2:37:53 PM (5 days ago) Apr 17
            to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
            Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry

            Brian Wilkerson voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Johnni Winther
            • Konstantin Shcheglov
            • Paul Berry
            Submit Requirements:
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 42
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-Attention: Paul Berry <paul...@google.com>
            Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Attention: Johnni Winther <johnni...@google.com>
            Gerrit-Comment-Date: Fri, 17 Apr 2026 18:37:50 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Paul Berry (Gerrit)

            unread,
            Apr 17, 2026, 2:50:57 PM (5 days ago) Apr 17
            to Konstantin Shcheglov, Brian Wilkerson, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
            Attention needed from Johnni Winther and Konstantin Shcheglov

            Paul Berry voted and added 1 comment

            Votes added by Paul Berry

            Code-Review+1

            1 comment

            Patchset-level comments
            Paul Berry . resolved

            Changes in tests/language lgtm.

            Related details

            Attention is currently required from:
            • Johnni Winther
            • Konstantin Shcheglov
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 42
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Attention: Johnni Winther <johnni...@google.com>
            Gerrit-Comment-Date: Fri, 17 Apr 2026 18:50:53 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Konstantin Shcheglov (Gerrit)

            unread,
            Apr 18, 2026, 1:32:42 AM (4 days ago) Apr 18
            to Paul Berry, Brian Wilkerson, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
            Attention needed from Johnni Winther

            Konstantin Shcheglov voted Commit-Queue+2

            Commit-Queue+2
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Johnni Winther
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 42
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-Attention: Johnni Winther <johnni...@google.com>
            Gerrit-Comment-Date: Sat, 18 Apr 2026 05:32:38 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Konstantin Shcheglov (Gerrit)

            unread,
            Apr 18, 2026, 1:40:30 AM (4 days ago) Apr 18
            to Paul Berry, Brian Wilkerson, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
            Attention needed from Johnni Winther

            Konstantin Shcheglov voted Commit-Queue+2

            Commit-Queue+2
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Johnni Winther
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 43
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-Attention: Johnni Winther <johnni...@google.com>
            Gerrit-Comment-Date: Sat, 18 Apr 2026 05:40:27 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

            unread,
            Apr 18, 2026, 2:06:31 AM (4 days ago) Apr 18
            to Konstantin Shcheglov, Paul Berry, Brian Wilkerson, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org

            dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

            Unreviewed changes

            42 is the latest approved patch-set.
            No files were changed between the latest approved patch-set and the submitted one.

            Change information

            Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Reviewed-by: Paul Berry <paul...@google.com>
            Reviewed-by: Brian Wilkerson <brianwi...@google.com>
            Commit-Queue: Konstantin Shcheglov <sche...@google.com>
            Files:
            • M DEPS
            • M pkg/_fe_analyzer_shared/messages.yaml
            • M pkg/analysis_server/lib/src/computer/computer_color.dart
            • M pkg/analysis_server/lib/src/computer/computer_document_highlights.dart
            • M pkg/analysis_server/lib/src/computer/computer_highlights.dart
            • M pkg/analysis_server/lib/src/computer/computer_hover.dart
            • M pkg/analysis_server/lib/src/computer/computer_inlay_hint.dart
            • M pkg/analysis_server/lib/src/computer/computer_outline.dart
            • M pkg/analysis_server/lib/src/computer/computer_selection_ranges.dart
            • M pkg/analysis_server/lib/src/computer/computer_signature.dart
            • M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart
            • M pkg/analysis_server/lib/src/flutter/flutter_outline_computer.dart
            • M pkg/analysis_server/lib/src/handler/legacy/completion_utils.dart
            • M pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/editable_arguments_mixin.dart
            • M pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_edit_argument.dart
            • M pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_editable_arguments.dart
            • M pkg/analysis_server/lib/src/lsp/handlers/handler_type_definition.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/identifier_helper.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/keyword_helper.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/label_helper.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart
            • M pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_await.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_key_to_constructors.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_missing_parameter.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_missing_parameter_named.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_missing_required_argument.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_required_keyword.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_super_constructor_invocation.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/add_type_annotation.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/bind_to_field.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/change_argument_name.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/change_to.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_add_all_to_spread.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_enum.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_field_formal_to_normal.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_flutter_child.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_flutter_children.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_for_each_to_for_loop.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_map_from_iterable_to_for_literal.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_to_declaring_parameter.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_to_generic_function_syntax.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_to_initializing_formal.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_to_named_arguments.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_to_secondary_constructor.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/convert_to_super_parameters.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/create_mixin.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/encapsulate_field.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_children.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/flutter_remove_widget.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/flutter_swap_with_child.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/flutter_swap_with_parent.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/flutter_wrap.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/inline_typedef.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/make_field_not_final.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/make_final.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/make_required_named_parameters_first.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/make_variable_nullable.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_annotation.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_argument.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_const.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_default_value.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_initializer.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_type_annotation.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_unnecessary_final.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_unused.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/remove_unused_parameter.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/rename_method_parameter.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/rename_to_camel_case.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/replace_colon_with_equals.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/replace_final_with_var.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/replace_null_with_closure.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/replace_with_decorated_box.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/replace_with_identifier.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/sort_child_property_last.dart
            • M pkg/analysis_server/lib/src/services/correction/dart/wrap_in_text.dart
            • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/code_template.dart
            • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart
            • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/modify_parameters.dart
            • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/rename.dart
            • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/rename_parameter.dart
            • M pkg/analysis_server/lib/src/services/correction/name_suggestion.dart
            • M pkg/analysis_server/lib/src/services/correction/util.dart
            • M pkg/analysis_server/lib/src/services/flutter/property.dart
            • M pkg/analysis_server/lib/src/services/flutter/widget_descriptions.dart
            • M pkg/analysis_server/lib/src/services/refactoring/agnostic/change_method_signature.dart
            • M pkg/analysis_server/lib/src/services/refactoring/framework/formal_parameter.dart
            • M pkg/analysis_server/lib/src/services/refactoring/framework/write_invocation_arguments.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/extract_local.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/extract_widget.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/rename_extension_member.dart
            • M pkg/analysis_server/lib/src/services/refactoring/legacy/rename_local.dart
            • M pkg/analysis_server/lib/src/services/snippets/dart_snippet_request.dart
            • M pkg/analysis_server/lib/src/status/utilities/ast_writer.dart
            • M pkg/analysis_server/test/analysis/get_hover_test.dart
            • M pkg/analysis_server/test/services/completion/dart/text_expectations.dart
            • M pkg/analysis_server/test/src/services/correction/assist/bind_to_field_test.dart
            • M pkg/analysis_server/test/src/utilities/extensions/range_factory_test.dart
            • M pkg/analysis_server/test/src/utilities/flutter_test.dart
            • M pkg/analysis_server/test/src/utilities/selection_test.dart
            • M pkg/analysis_server/test/stress/completion/completion_runner.dart
            • M pkg/analysis_server/tool/code_completion/code_metrics.dart
            • M pkg/analysis_server/tool/code_completion/relevance_metrics.dart
            • M pkg/analysis_server/tool/code_completion/relevance_table_generator.dart
            • M pkg/analysis_server/tool/code_completion/visitors.dart
            • M pkg/analysis_server/tool/codebase/failing_tests.dart
            • M pkg/analysis_server_plugin/CHANGELOG.md
            • M pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart
            • M pkg/analysis_server_plugin/lib/src/utilities/selection.dart
            • M pkg/analysis_server_plugin/pubspec.yaml
            • M pkg/analyzer/CHANGELOG.md
            • M pkg/analyzer/api.txt
            • M pkg/analyzer/lib/analysis_rule/rule_visitor_registry.g.dart
            • M pkg/analyzer/lib/dart/ast/ast.dart
            • M pkg/analyzer/lib/dart/ast/visitor.g.dart
            • M pkg/analyzer/lib/dart/element/element.dart
            • M pkg/analyzer/lib/src/dart/analysis/defined_names.dart
            • M pkg/analyzer/lib/src/dart/analysis/driver.dart
            • M pkg/analyzer/lib/src/dart/analysis/index.dart
            • M pkg/analyzer/lib/src/dart/analysis/referenced_names.dart
            • M pkg/analyzer/lib/src/dart/analysis/search.dart
            • M pkg/analyzer/lib/src/dart/ast/ast.dart
            • M pkg/analyzer/lib/src/dart/ast/ast.g.dart
            • M pkg/analyzer/lib/src/dart/ast/element_locator.dart
            • M pkg/analyzer/lib/src/dart/ast/extensions.dart
            • M pkg/analyzer/lib/src/dart/ast/to_source_visitor.dart
            • M pkg/analyzer/lib/src/dart/ast/utilities.dart
            • M pkg/analyzer/lib/src/dart/constant/constant_verifier.dart
            • M pkg/analyzer/lib/src/dart/constant/evaluation.dart
            • M pkg/analyzer/lib/src/dart/constant/potentially_constant.dart
            • M pkg/analyzer/lib/src/dart/constant/utilities.dart
            • M pkg/analyzer/lib/src/dart/element/element.dart
            • M pkg/analyzer/lib/src/dart/element/extensions.dart
            • M pkg/analyzer/lib/src/dart/element/member.dart
            • M pkg/analyzer/lib/src/dart/resolver/element_binding_visitor.dart
            • M pkg/analyzer/lib/src/dart/resolver/exit_detector.dart
            • M pkg/analyzer/lib/src/dart/resolver/extension_member_resolver.dart
            • M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
            • M pkg/analyzer/lib/src/dart/resolver/invocation_inferrer.dart
            • M pkg/analyzer/lib/src/dart/resolver/method_invocation_resolver.dart
            • M pkg/analyzer/lib/src/dart/resolver/record_literal_resolver.dart
            • M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
            • M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
            • M pkg/analyzer/lib/src/dart/resolver/typed_literal_resolver.dart
            • M pkg/analyzer/lib/src/diagnostic/diagnostic_factory.dart
            • M pkg/analyzer/lib/src/error/annotation_verifier.dart
            • M pkg/analyzer/lib/src/error/best_practices_verifier.dart
            • M pkg/analyzer/lib/src/error/const_argument_verifier.dart
            • M pkg/analyzer/lib/src/error/constructor_fields_verifier.dart
            • M pkg/analyzer/lib/src/error/dead_code_verifier.dart
            • M pkg/analyzer/lib/src/error/deprecated_functionality_verifier.dart
            • M pkg/analyzer/lib/src/error/duplicate_definition_verifier.dart
            • M pkg/analyzer/lib/src/error/element_usage_detector.dart
            • M pkg/analyzer/lib/src/error/error_handler_verifier.dart
            • M pkg/analyzer/lib/src/error/null_safe_api_verifier.dart
            • M pkg/analyzer/lib/src/error/required_parameters_verifier.dart
            • M pkg/analyzer/lib/src/error/super_formal_parameters_verifier.dart
            • M pkg/analyzer/lib/src/error/type_arguments_verifier.dart
            • M pkg/analyzer/lib/src/error/unused_local_elements_verifier.dart
            • M pkg/analyzer/lib/src/error/use_result_verifier.dart
            • M pkg/analyzer/lib/src/error/widget_preview_verifier.dart
            • M pkg/analyzer/lib/src/fasta/ast_builder.dart
            • M pkg/analyzer/lib/src/fine/manifest_ast.dart
            • M pkg/analyzer/lib/src/generated/element_resolver.dart
            • M pkg/analyzer/lib/src/generated/error_detection_helpers.dart
            • M pkg/analyzer/lib/src/generated/error_verifier.dart
            • M pkg/analyzer/lib/src/generated/ffi_verifier.dart
            • M pkg/analyzer/lib/src/generated/resolver.dart
            • M pkg/analyzer/lib/src/generated/sdk.dart
            • M pkg/analyzer/lib/src/generated/static_type_analyzer.dart
            • M pkg/analyzer/lib/src/hint/sdk_constraint_verifier.dart
            • M pkg/analyzer/lib/src/lint/linter_visitor.g.dart
            • M pkg/analyzer/lib/src/summary2/ast_binary_flags.dart
            • M pkg/analyzer/lib/src/summary2/ast_binary_reader.dart
            • M pkg/analyzer/lib/src/summary2/ast_binary_tag.dart
            • M pkg/analyzer/lib/src/summary2/ast_binary_writer.dart
            • M pkg/analyzer/lib/src/summary2/default_value_resolver.dart
            • M pkg/analyzer/lib/src/summary2/detach_nodes.dart
            • M pkg/analyzer/lib/src/summary2/element_builder.dart
            • M pkg/analyzer/lib/src/summary2/function_type_builder.dart
            • M pkg/analyzer/lib/src/summary2/informative_data.dart
            • M pkg/analyzer/lib/src/summary2/instance_member_inferrer.dart
            • M pkg/analyzer/lib/src/summary2/metadata_resolver.dart
            • M pkg/analyzer/lib/src/summary2/named_type_builder.dart
            • M pkg/analyzer/lib/src/summary2/not_serializable_nodes.dart
            • M pkg/analyzer/lib/src/summary2/reference_resolver.dart
            • M pkg/analyzer/lib/src/summary2/simply_bounded.dart
            • M pkg/analyzer/lib/src/summary2/top_level_inference.dart
            • M pkg/analyzer/lib/src/summary2/type_alias.dart
            • M pkg/analyzer/lib/src/summary2/types_builder.dart
            • M pkg/analyzer/lib/src/test_utilities/find_element2.dart
            • M pkg/analyzer/lib/src/test_utilities/find_node.dart
            • M pkg/analyzer/lib/src/util/ast_data_extractor.dart
            • M pkg/analyzer/lib/src/utilities/extensions/element.dart
            • M pkg/analyzer/lib/src/utilities/extensions/flutter.dart
            • M pkg/analyzer/lib/src/wolf/ir/ast_to_ir.dart
            • M pkg/analyzer/messages.yaml
            • M pkg/analyzer/pubspec.yaml
            • M pkg/analyzer/test/dart/ast/ast_test.dart
            • M pkg/analyzer/test/dart/element/fragment_offset_test.dart
            • M pkg/analyzer/test/generated/complex_parser_test.dart
            • M pkg/analyzer/test/generated/expression_parser_test.dart
            • M pkg/analyzer/test/generated/formal_parameter_parser_test.dart
            • M pkg/analyzer/test/generated/non_error_resolver_test.dart
            • M pkg/analyzer/test/generated/recovery_parser_test.dart
            • M pkg/analyzer/test/generated/simple_parser_test.dart
            • M pkg/analyzer/test/generated/simple_resolver_test.dart
            • M pkg/analyzer/test/generated/statement_parser_test.dart
            • M pkg/analyzer/test/generated/static_type_analyzer_test.dart
            • M pkg/analyzer/test/generated/strong_mode_test.dart
            • M pkg/analyzer/test/generated/utilities_test.dart
            • M pkg/analyzer/test/src/dart/analysis/results/get_element_declaration_test.dart
            • M pkg/analyzer/test/src/dart/analysis/search_test.dart
            • M pkg/analyzer/test/src/dart/ast/ast_test.dart
            • M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
            • M pkg/analyzer/test/src/dart/constant/potentially_constant_test.dart
            • M pkg/analyzer/test/src/dart/parser/class_test.dart
            • M pkg/analyzer/test/src/dart/resolution/enum_test.dart
            • M pkg/analyzer/test/src/dart/resolution/function_expression_invocation_test.dart
            • M pkg/analyzer/test/src/dart/resolution/function_typed_formal_parameter_test.dart
            • M pkg/analyzer/test/src/dart/resolution/instance_creation_test.dart
            • M pkg/analyzer/test/src/dart/resolution/method_invocation_test.dart
            • M pkg/analyzer/test/src/dart/resolution/node_text_expectations.dart
            • M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
            • M pkg/analyzer/test/src/dart/resolution/property_access_test.dart
            • M pkg/analyzer/test/src/dart/resolution/record_literal_test.dart
            • M pkg/analyzer/test/src/dart/resolution/switch_statement_test.dart
            • M pkg/analyzer/test/src/dart/resolution/type_inference/function_test.dart
            • M pkg/analyzer/test/src/dart/resolution/type_inference/inference_update_1_test.dart
            • M pkg/analyzer/test/src/dart/resolution/while_statement_test.dart
            • M pkg/analyzer/test/src/diagnostics/field_initializer_outside_constructor_test.dart
            • M pkg/analyzer/test/src/diagnostics/inference_failure_on_untyped_parameter_test.dart
            • M pkg/analyzer/test/src/diagnostics/initializer_for_static_field_test.dart
            • M pkg/analyzer/test/src/diagnostics/main_first_positional_parameter_type_test.dart
            • M pkg/analyzer/test/src/fasta/ast_builder_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/extra_code_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/invalid_code_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/annotation_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/assert_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/break_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/continue_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/do_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/for_each_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/for_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/if_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/index_expression_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/local_variable_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/return_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/switch_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/try_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/while_statement_test.dart
            • M pkg/analyzer/test/src/fasta/recovery/partial_code/yield_statement_test.dart
            • M pkg/analyzer/test/src/summary/elements/class_test.dart
            • M pkg/analyzer/test/src/summary/elements/const_test.dart
            • M pkg/analyzer/test/src/summary/elements/default_value_test.dart
            • M pkg/analyzer/test/src/summary/elements/enum_test.dart
            • M pkg/analyzer/test/src/summary/elements/metadata_test.dart
            • M pkg/analyzer/test/src/summary/resolved_ast_printer.dart
            • M pkg/analyzer/test/util/ast_type_matchers.dart
            • M pkg/analyzer_plugin/CHANGELOG.md
            • M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
            • M pkg/analyzer_plugin/lib/src/utilities/completion/completion_target.dart
            • M pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart
            • M pkg/analyzer_plugin/lib/src/utilities/navigation/navigation_dart.dart
            • M pkg/analyzer_plugin/lib/src/utilities/visitors/local_declaration_visitor.dart
            • M pkg/analyzer_plugin/lib/utilities/completion/type_member_contributor.dart
            • M pkg/analyzer_plugin/pubspec.yaml
            • M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
            • M pkg/analyzer_plugin/test/utilities/range_factory_test.dart
            • M pkg/analyzer_testing/CHANGELOG.md
            • M pkg/analyzer_testing/pubspec.yaml
            • M pkg/analyzer_utilities/tool/messages/use_literate_api_in_analyzer.dart
            • M pkg/analyzer_utilities/tool/messages/use_new_with_arguments.dart
            • M pkg/front_end/testcases/extension_types/with_dependencies/issue53209_2/main.dart.textual_outline.expect
            • M pkg/front_end/testcases/extension_types/with_dependencies/issue53209_2/main.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/body_without_primary.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/body_without_primary.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/const_class.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/const_class.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/const_parameters.dart.textual_outline.expect
            • A pkg/front_end/testcases/primary_constructors/const_parameters.dart.textual_outline_modelled.expect
            • A pkg/front_end/testcases/primary_constructors/duplicate_initialization.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/extension_type.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/extension_type.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/extension_type_fields.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/extension_type_parameter_type_inference.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/field_initializers.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/field_initializers.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/generic_primary_constructor.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/generic_primary_constructor.dart.textual_outline_modelled.expect
            • A pkg/front_end/testcases/primary_constructors/issue62935.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/mixin_class.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/mixin_class.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/parameter_assignment.dart.textual_outline.expect
            • A pkg/front_end/testcases/primary_constructors/parameter_assignment.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/parameter_scope.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/parameter_scope.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/primary_and_generative.dart.textual_outline.expect
            • M pkg/front_end/testcases/primary_constructors/primary_and_generative.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/primary_constructors/private_named_declaring_parameters.dart.textual_outline.expect
            • A pkg/front_end/testcases/primary_constructors/private_named_declaring_parameters.dart.textual_outline_modelled.expect
            • A pkg/front_end/testcases/primary_constructors/redirecting_error.dart.textual_outline_modelled.expect
            • A pkg/front_end/testcases/primary_constructors/wildcards.dart.textual_outline_modelled.expect
            • M pkg/front_end/testcases/textual_outline.status
            • M pkg/linter/lib/src/extensions.dart
            • M pkg/linter/lib/src/rules/always_specify_types.dart
            • M pkg/linter/lib/src/rules/annotate_overrides.dart
            • M pkg/linter/lib/src/rules/avoid_annotating_with_dynamic.dart
            • M pkg/linter/lib/src/rules/avoid_dynamic_calls.dart
            • M pkg/linter/lib/src/rules/avoid_final_parameters.dart
            • M pkg/linter/lib/src/rules/avoid_futureor_void.dart
            • M pkg/linter/lib/src/rules/avoid_init_to_null.dart
            • M pkg/linter/lib/src/rules/avoid_print.dart
            • M pkg/linter/lib/src/rules/avoid_redundant_argument_values.dart
            • M pkg/linter/lib/src/rules/avoid_shadowing_type_parameters.dart
            • M pkg/linter/lib/src/rules/avoid_type_to_string.dart
            • M pkg/linter/lib/src/rules/avoid_types_on_closure_parameters.dart
            • M pkg/linter/lib/src/rules/avoid_unnecessary_containers.dart
            • M pkg/linter/lib/src/rules/collection_methods_unrelated_type.dart
            • M pkg/linter/lib/src/rules/deprecated_member_use_from_same_package.dart
            • M pkg/linter/lib/src/rules/library_private_types_in_public_api.dart
            • M pkg/linter/lib/src/rules/no_leading_underscores_for_local_identifiers.dart
            • M pkg/linter/lib/src/rules/non_constant_identifier_names.dart
            • M pkg/linter/lib/src/rules/noop_primitive_operations.dart
            • M pkg/linter/lib/src/rules/null_closures.dart
            • M pkg/linter/lib/src/rules/overridden_fields.dart
            • M pkg/linter/lib/src/rules/parameter_assignments.dart
            • M pkg/linter/lib/src/rules/prefer_const_literals_to_create_immutables.dart
            • M pkg/linter/lib/src/rules/prefer_contains.dart
            • M pkg/linter/lib/src/rules/prefer_final_parameters.dart
            • M pkg/linter/lib/src/rules/prefer_for_elements_to_map_fromIterable.dart
            • M pkg/linter/lib/src/rules/prefer_initializing_formals.dart
            • M pkg/linter/lib/src/rules/prefer_int_literals.dart
            • M pkg/linter/lib/src/rules/prefer_void_to_null.dart
            • M pkg/linter/lib/src/rules/sized_box_for_whitespace.dart
            • M pkg/linter/lib/src/rules/sized_box_shrink_expand.dart
            • M pkg/linter/lib/src/rules/sort_child_properties_last.dart
            • M pkg/linter/lib/src/rules/strict_top_level_inference.dart
            • M pkg/linter/lib/src/rules/type_annotate_public_apis.dart
            • M pkg/linter/lib/src/rules/unnecessary_final.dart
            • M pkg/linter/lib/src/rules/unnecessary_lambdas.dart
            • M pkg/linter/lib/src/rules/unnecessary_null_checks.dart
            • M pkg/linter/lib/src/rules/unnecessary_parenthesis.dart
            • M pkg/linter/lib/src/rules/unnecessary_unawaited.dart
            • M pkg/linter/lib/src/rules/use_build_context_synchronously.dart
            • M pkg/linter/lib/src/rules/use_colored_box.dart
            • M pkg/linter/lib/src/rules/use_decorated_box.dart
            • M pkg/linter/lib/src/rules/use_function_type_syntax_for_parameters.dart
            • M pkg/linter/lib/src/rules/use_super_parameters.dart
            • M pkg/linter/lib/src/rules/valid_regexps.dart
            • M pkg/linter/lib/src/rules/var_with_no_type_annotation.dart
            • M pkg/linter/lib/src/rules/void_checks.dart
            • M pkg/linter/lib/src/util/dart_type_utilities.dart
            • M pkg/linter/lib/src/util/obvious_types.dart
            • M pkg/linter/lib/src/util/variance_checker.dart
            • M pkg/linter/test/rules/avoid_annotating_with_dynamic_test.dart
            • M pkg/linter/test/rules/avoid_print_test.dart
            • M pkg/linter/test/rules/avoid_redundant_argument_values_test.dart
            • M pkg/linter/test/rules/omit_obvious_local_variable_types_test.dart
            • M pkg/linter/test/rules/use_build_context_synchronously_test.dart
            • M pkg/linter/test/rules/use_function_type_syntax_for_parameters_test.dart
            • M pkg/linter/test/scope_util_test.dart
            • M pkg/linter/tool/checks/rules/visit_registered_nodes.dart
            • M pkg/scrape/example/annotation_arguments.dart
            • M pkg/scrape/example/build_control_flow.dart
            • M pkg/scrape/example/nesting.dart
            • M pkg/scrape/example/null_aware.dart
            • M pkg/scrape/example/superclass_parameters.dart
            • M tests/language/parameter/initializer1_test.dart
            • M tests/language/parameter/initializer4_test.dart
            • M tests/language/parameter/initializer7_test.dart
            • M tests/language/regress/regress26855_test.dart
            • M tests/lib/mirrors/metadata_constructor_arguments_test.dart
            Change size: XL
            Delta: 385 files changed, 6121 insertions(+), 6090 deletions(-)
            Branch: refs/heads/main
            Submit Requirements:
            • requirement satisfiedCode-Review: +1 by Brian Wilkerson, +1 by Paul Berry
            Open in Gerrit
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: merged
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 44
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            open
            diffy
            satisfied_requirement

            Ivan Inozemtsev (Gerrit)

            unread,
            Apr 21, 2026, 3:58:55 AM (yesterday) Apr 21
            to Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, Brian Wilkerson, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org

            Ivan Inozemtsev added 1 comment

            Patchset-level comments
            File-level comment, Patchset 44 (Latest):
            Ivan Inozemtsev . unresolved

            now the roll CL requires 6 extra owner approvals, as the google3 hotfix is not trivial and Morgan refuses to GA it. Did it have to be so breaking?

            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 44
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-CC: Ivan Inozemtsev <iinoz...@google.com>
            Gerrit-Comment-Date: Tue, 21 Apr 2026 07:58:51 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            open
            diffy

            Ryan Macnak (Gerrit)

            unread,
            Apr 21, 2026, 12:47:27 PM (23 hours ago) Apr 21
            to Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, Ivan Inozemtsev, Paul Berry, Brian Wilkerson, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org

            Ryan Macnak added 1 comment

            Patchset-level comments
            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 44
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-CC: Ivan Inozemtsev <iinoz...@google.com>
            Gerrit-CC: Ryan Macnak <rma...@google.com>
            Gerrit-Comment-Date: Tue, 21 Apr 2026 16:47:24 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            open
            diffy

            Konstantin Shcheglov (Gerrit)

            unread,
            Apr 21, 2026, 3:47:22 PM (20 hours ago) Apr 21
            to dart-...@luci-project-accounts.iam.gserviceaccount.com, Ryan Macnak, Ivan Inozemtsev, Paul Berry, Brian Wilkerson, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org

            Konstantin Shcheglov added 1 comment

            Patchset-level comments
            Konstantin Shcheglov
            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: sdk
            Gerrit-Branch: main
            Gerrit-Change-Id: I44754a48f66a0b58851d7c20fcfa61f7fb1b555a
            Gerrit-Change-Number: 488624
            Gerrit-PatchSet: 44
            Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
            Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
            Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
            Gerrit-Reviewer: Paul Berry <paul...@google.com>
            Gerrit-CC: Ivan Inozemtsev <iinoz...@google.com>
            Gerrit-CC: Ryan Macnak <rma...@google.com>
            Gerrit-Comment-Date: Tue, 21 Apr 2026 19:47:19 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Comment-In-Reply-To: Ryan Macnak <rma...@google.com>
            satisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages