[M] Change in dart/sdk[main]: DeCo. Use more general FormalParameterImpl.fullTypeAnnotation
Paul Berry (Gerrit)
Paul Berry added 1 comment![]( "Open in Gerrit")
}What happens if `fullTypeAnnotation` is `null`? It seems like in that case we wouldn't report any diagnostic, which seems like an unintentional change in behavior.
Related details
- Johnni Winther
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
What happens if `fullTypeAnnotation` is `null`? It seems like in that case we wouldn't report any diagnostic, which seems like an unintentional change in behavior.
In extension types you can get `Never` only if you write it explicitly, as simple or default formal parameter. In these cases `fullTypeAnnotation` cannot be `null`. Maybe it would be easier if I wrote this explicitly in the code instead of adding a new getter. At least until we get two more use cases :-P
Let me try to do this...
Related details
- Johnni Winther
- Paul Berry
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Konstantin Shcheglov
| Commit-Queue | +1 |
2 comments
Konstantin ShcheglovWhat happens if `fullTypeAnnotation` is `null`? It seems like in that case we wouldn't report any diagnostic, which seems like an unintentional change in behavior.
In extension types you can get `Never` only if you write it explicitly, as simple or default formal parameter. In these cases `fullTypeAnnotation` cannot be `null`. Maybe it would be easier if I wrote this explicitly in the code instead of adding a new getter. At least until we get two more use cases :-P
Let me try to do this...
Done
Related details
- Johnni Winther
- Paul Berry
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Paul Berry voted and added 2 comments![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
2 comments
It looks like the commit message needs to be rewritten; it still refers to `fullTypeAnnotation`.
Lgtm assuming the commit message is rewritten.
Konstantin ShcheglovWhat happens if `fullTypeAnnotation` is `null`? It seems like in that case we wouldn't report any diagnostic, which seems like an unintentional change in behavior.
Konstantin ShcheglovIn extension types you can get `Never` only if you write it explicitly, as simple or default formal parameter. In these cases `fullTypeAnnotation` cannot be `null`. Maybe it would be easier if I wrote this explicitly in the code instead of adding a new getter. At least until we get two more use cases :-P
Let me try to do this...
Done
- Johnni Winther
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- Johnni Winther
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
DeCo. Use more general FormalParameterImpl.fullTypeAnnotation
Replace `ExtensionTypeDeclarationImpl.fieldType` with more general
`representationFormalParameter`.
Use `representationFormalParameter` when reporting
EXTENSION_TYPE_REPRESENTATION_TYPE_BOTTOM.
In the extension type linker, rely on `element.representation.type` for
dependency analysis and evaluation.
- M pkg/analyzer/lib/src/dart/ast/ast.dart
- M pkg/analyzer/lib/src/generated/error_verifier.dart
- M pkg/analyzer/lib/src/summary2/extension_type.dart
Code-Review: +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |