[S] Change in dart/sdk[main]: [analyzer] Fixes `undefined_identifier` case for static `Object` members

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Aug 8, 2025, 1:01:38 PM8/8/25
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[analyzer] Fixes `undefined_identifier` case for static `Object` members
Change-Id: I51010e118894151cbe8bbe9fd989eb7487a08251

Change information

Files:
  • M pkg/analyzer/lib/src/dart/element/element.dart
  • M pkg/analyzer/lib/src/dart/resolver/type_property_resolver.dart
  • M pkg/analyzer/test/src/diagnostics/undefined_identifier_test.dart
Change size: S
Delta: 3 files changed, 26 insertions(+), 7 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I51010e118894151cbe8bbe9fd989eb7487a08251
Gerrit-Change-Number: 444444
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Aug 8, 2025, 1:06:51 PM8/8/25
to Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Felipe Morschel added 1 comment

File pkg/analyzer/lib/src/dart/element/element.dart
Line 4463, Patchset 1 (Latest): Iterable<InternalPropertyAccessorElement> _implementationsOfGetter(
Felipe Morschel . unresolved

Maybe we could add a TODO to see if we can turn these three methods into one with more parameters. WDYT @sche...@google.com?

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I51010e118894151cbe8bbe9fd989eb7487a08251
Gerrit-Change-Number: 444444
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 17:06:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages