[S] Change in dart/sdk[main]: Core libs: Introduce Deprecated.optional, a new annotation.

0 views
Skip to first unread message

Stephen Adams (Gerrit)

unread,
Sep 25, 2025, 10:32:05 PM (3 days ago) Sep 25
to Samuel Rawlins, Lasse Nielsen, Martin Kustermann, Commit Queue, rev...@dartlang.org
Attention needed from Lasse Nielsen, Martin Kustermann and Samuel Rawlins

Stephen Adams voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lasse Nielsen
  • Martin Kustermann
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCore-Library-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iecc60f9909be708597b8571670585cc1b8508afe
Gerrit-Change-Number: 451546
Gerrit-PatchSet: 3
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Stephen Adams <s...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Lasse Nielsen <l...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 02:32:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Martin Kustermann (Gerrit)

unread,
Sep 26, 2025, 3:11:34 AM (3 days ago) Sep 26
to Samuel Rawlins, Stephen Adams, Lasse Nielsen, Commit Queue, rev...@dartlang.org
Attention needed from Lasse Nielsen and Samuel Rawlins

Martin Kustermann voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lasse Nielsen
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCore-Library-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iecc60f9909be708597b8571670585cc1b8508afe
Gerrit-Change-Number: 451546
Gerrit-PatchSet: 3
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Stephen Adams <s...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Lasse Nielsen <l...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 07:11:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lasse Nielsen (Gerrit)

unread,
Sep 26, 2025, 4:23:18 AM (3 days ago) Sep 26
to Samuel Rawlins, Martin Kustermann, Stephen Adams, Commit Queue, rev...@dartlang.org
Attention needed from Samuel Rawlins

Lasse Nielsen voted and added 1 comment

Votes added by Lasse Nielsen

Code-Review+1

1 comment

File sdk/lib/core/annotations.dart
Line 206, Patchset 3 (Latest): const Deprecated.optional([this.message]) : _kind = _DeprecationKind.optional;
Lasse Nielsen . unresolved

(Could have a default message of "pass an argument for this parameter". But that can probably be handled in the warning code, doesn't have to be here.)

Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCore-Library-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iecc60f9909be708597b8571670585cc1b8508afe
    Gerrit-Change-Number: 451546
    Gerrit-PatchSet: 3
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
    Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Stephen Adams <s...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 08:23:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Sep 28, 2025, 8:51:44 PM (13 hours ago) Sep 28
    to Lasse Nielsen, Martin Kustermann, Stephen Adams, Commit Queue, rev...@dartlang.org

    Samuel Rawlins added 1 comment

    File sdk/lib/core/annotations.dart
    Line 206, Patchset 3 (Latest): const Deprecated.optional([this.message]) : _kind = _DeprecationKind.optional;
    Lasse Nielsen . resolved

    (Could have a default message of "pass an argument for this parameter". But that can probably be handled in the warning code, doesn't have to be here.)

    Samuel Rawlins

    Hmm yeah I think it makes sense to leave the default message blank. And the warning code has good text, I think.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCore-Library-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iecc60f9909be708597b8571670585cc1b8508afe
    Gerrit-Change-Number: 451546
    Gerrit-PatchSet: 3
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
    Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Stephen Adams <s...@google.com>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 00:51:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Lasse Nielsen <l...@google.com>
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Sep 28, 2025, 8:51:49 PM (13 hours ago) Sep 28
    to Lasse Nielsen, Martin Kustermann, Stephen Adams, Commit Queue, rev...@dartlang.org

    Samuel Rawlins voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCore-Library-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iecc60f9909be708597b8571670585cc1b8508afe
    Gerrit-Change-Number: 451546
    Gerrit-PatchSet: 3
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
    Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Stephen Adams <s...@google.com>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 00:51:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Sep 28, 2025, 11:36:11 PM (10 hours ago) Sep 28
    to Lasse Nielsen, Martin Kustermann, Stephen Adams, Commit Queue, rev...@dartlang.org
    Gerrit-Comment-Date: Mon, 29 Sep 2025 03:36:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Sep 28, 2025, 11:36:47 PM (10 hours ago) Sep 28
    to Samuel Rawlins, Lasse Nielsen, Martin Kustermann, Stephen Adams, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    Core libs: Introduce Deprecated.optional, a new annotation.

    Also correct a copy/paste error in the Deprecated.new doc comment.

    Work towards https://github.com/dart-lang/sdk/issues/60504
    Change-Id: Iecc60f9909be708597b8571670585cc1b8508afe
    Reviewed-by: Lasse Nielsen <l...@google.com>
    Commit-Queue: Samuel Rawlins <sraw...@google.com>
    Reviewed-by: Martin Kustermann <kuste...@google.com>
    Reviewed-by: Stephen Adams <s...@google.com>
    Files:
    • M sdk/lib/core/annotations.dart
    Change size: S
    Delta: 1 file changed, 31 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lasse Nielsen, +1 by Stephen Adams, +1 by Martin Kustermann
    • requirement satisfiedCore-Library-Review: Code-Review+1 by Lasse Nielsen, Code-Review+1 by Stephen Adams, Code-Review+1 by Martin Kustermann
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iecc60f9909be708597b8571670585cc1b8508afe
    Gerrit-Change-Number: 451546
    Gerrit-PatchSet: 4
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages