[M] Change in dart/sdk[main]: Add more fine grained timings while computing fixes

0 views
Skip to first unread message

Keerti Parthasarathy (Gerrit)

unread,
1:27 PM (7 hours ago) 1:27 PM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If610a4dcf8a33143a623344f3bb4ad0a49cfd022
Gerrit-Change-Number: 491680
Gerrit-PatchSet: 2
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 17:27:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
1:51 PM (7 hours ago) 1:51 PM
to Keerti Parthasarathy, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If610a4dcf8a33143a623344f3bb4ad0a49cfd022
Gerrit-Change-Number: 491680
Gerrit-PatchSet: 2
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 17:51:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
1:55 PM (7 hours ago) 1:55 PM
to Keerti Parthasarathy, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Samuel Rawlins . resolved

Excellent!

Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If610a4dcf8a33143a623344f3bb4ad0a49cfd022
Gerrit-Change-Number: 491680
Gerrit-PatchSet: 2
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 17:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
2:15 PM (6 hours ago) 2:15 PM
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Keerti Parthasarathy voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If610a4dcf8a33143a623344f3bb4ad0a49cfd022
Gerrit-Change-Number: 491680
Gerrit-PatchSet: 2
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 18:15:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
2:15 PM (6 hours ago) 2:15 PM
to Keerti Parthasarathy, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Add more fine grained timings while computing fixes
Change-Id: If610a4dcf8a33143a623344f3bb4ad0a49cfd022
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Files:
  • M pkg/analysis_server/lib/src/handler/legacy/edit_get_fixes.dart
  • M pkg/analysis_server/lib/src/lsp/handlers/code_actions/code_action_computer.dart
  • M pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart
  • M pkg/analysis_server/lib/src/status/pages/timing_page.dart
  • M pkg/analysis_server_plugin/lib/src/correction/fix_processor.dart
Change size: M
Delta: 5 files changed, 77 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Samuel Rawlins, +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If610a4dcf8a33143a623344f3bb4ad0a49cfd022
Gerrit-Change-Number: 491680
Gerrit-PatchSet: 3
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages