[XL] Change in dart/sdk[main]: [cfe] Report extension access type parameter bounds before lowering
0 views
Skip to first unread message
Chloe Stefantsova (Gerrit)
Sep 1, 2025, 4:17:58 AMSep 1
to Johnni Winther, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Chloe Stefantsova voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Sep 1, 2025, 6:21:18 AMSep 1
to Erik Ernst, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova and Erik Ernst
Johnni Winther added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Chloe Stefantsova
- Erik Ernst
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chloe Stefantsova (Gerrit)
Sep 1, 2025, 6:25:27 AMSep 1
to Johnni Winther, Chloe Stefantsova, Erik Ernst, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Erik Ernst and Johnni Winther
Chloe Stefantsova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Chloe Stefantsova
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Erik Ernst
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Ernst (Gerrit)
Sep 1, 2025, 6:30:16 AMSep 1
to Johnni Winther, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Erik Ernst voted and added 2 comments![]( "Open in Gerrit")
Votes added by Erik Ernst
| Code-Review | +1 |
2 comments
Patchset-level comments
Erik Ernst . resolved
LGTM
File tests/language/inference/issue_61370_2_error_test.dart
Line 21, Patchset 5 (Latest):
// [cfe] Type argument 'Iterable<int> Function() Function(Iterable<int> Function())' doesn't conform to the bound 'Iterable<int?> Function() Function(Iterable<int?> Function())' of the type variable 'Y' on 'm'.Erik Ernst . resolved
Oh, that's a very welcome change!
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Sep 1, 2025, 6:42:49 AMSep 1
to Erik Ernst, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Johnni Winther voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Sep 1, 2025, 7:00:03 AMSep 1
to Johnni Winther, Erik Ernst, Chloe Stefantsova, dart-fe-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cfe] Report extension access type parameter bounds before lowering
This changes the checking of type parameter bounds to be performed before lowering.
Change-Id: I4f6753359b68c9d5e7daa74be8958d3be8b6c104
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447781
Reviewed-by: Erik Ernst <eer...@google.com>
Commit-Queue: Johnni Winther <johnni...@google.com>
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>
Files:
- M pkg/front_end/lib/src/kernel/expression_generator.dart
- M pkg/front_end/lib/src/kernel/internal_ast.dart
- M pkg/front_end/lib/src/source/source_library_builder.dart
- M pkg/front_end/lib/src/type_inference/inference_visitor.dart
- M pkg/front_end/lib/src/type_inference/inference_visitor_base.dart
- M pkg/front_end/lib/src/type_inference/object_access_target.dart
- M pkg/front_end/test/text_representation/internal_ast_text_representation_test.dart
- M pkg/front_end/testcases/extensions/check_bounds.dart
- M pkg/front_end/testcases/extensions/check_bounds.dart.strong.expect
- M pkg/front_end/testcases/extensions/check_bounds.dart.strong.modular.expect
- M pkg/front_end/testcases/extensions/check_bounds.dart.strong.outline.expect
- M pkg/front_end/testcases/extensions/check_bounds.dart.strong.transformed.expect
- M tests/language/extension_methods/static_extension_bounds_error_test.dart
- M tests/language/inference/issue_61370_2_error_test.dart
- M tests/language/inference/issue_61370_error_test.dart
Change size: XL
Delta: 15 files changed, 1232 insertions(+), 1063 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chloe Stefantsova, +1 by Erik Ernst
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages