[XS] Change in dart/sdk[main]: api_summary: skipping too slow test

0 views
Skip to first unread message

Kevin Moore (Gerrit)

unread,
May 12, 2026, 5:41:46 PM (15 hours ago) May 12
to Mark Zhou, Paul Berry, rev...@dartlang.org
Attention needed from Mark Zhou and Paul Berry

Kevin Moore voted and added 1 comment

Votes added by Kevin Moore

Auto-Submit+1
Commit-Queue+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Zhou
  • Paul Berry
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icfcfda87008d6db9b0ed08da950919bd2ee9c2f2
Gerrit-Change-Number: 503140
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Mark Zhou <mark...@google.com>
Gerrit-Comment-Date: Tue, 12 May 2026 21:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Zhou (Gerrit)

unread,
May 12, 2026, 5:42:33 PM (15 hours ago) May 12
to Kevin Moore, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, rev...@dartlang.org
Attention needed from Kevin Moore and Paul Berry

Mark Zhou voted and added 1 comment

Votes added by Mark Zhou

Code-Review+1

1 comment

Patchset-level comments
Mark Zhou . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Moore
  • Paul Berry
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icfcfda87008d6db9b0ed08da950919bd2ee9c2f2
Gerrit-Change-Number: 503140
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Kevin Moore <kev...@google.com>
Gerrit-Comment-Date: Tue, 12 May 2026 21:42:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Paul Berry (Gerrit)

unread,
May 12, 2026, 5:44:31 PM (15 hours ago) May 12
to Kevin Moore, Mark Zhou, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Kevin Moore

Paul Berry added 1 comment

Patchset-level comments
Paul Berry . unresolved

I would rather see this fixed by adjusting the test timeout in the correct way rather than just skipping the test. See my other comment: https://dart-review.googlesource.com/c/sdk/+/502840/comments/812b1009_13eab40b

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Moore
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icfcfda87008d6db9b0ed08da950919bd2ee9c2f2
Gerrit-Change-Number: 503140
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Kevin Moore <kev...@google.com>
Gerrit-Comment-Date: Tue, 12 May 2026 21:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Kevin Moore (Gerrit)

unread,
12:48 AM (8 hours ago) 12:48 AM
to Mark Zhou, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, rev...@dartlang.org
Attention needed from Mark Zhou

Kevin Moore voted and added 1 comment

Votes added by Kevin Moore

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Zhou
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icfcfda87008d6db9b0ed08da950919bd2ee9c2f2
Gerrit-Change-Number: 503140
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Mark Zhou <mark...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 04:48:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages