[M] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound arguments to FfiCalls.

1 view
Skip to first unread message

Tess Strickland (Gerrit)

unread,
Jun 18, 2026, 11:37:28 AM (6 days ago) Jun 18
to Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

Tess Strickland voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ibeae6dc4213f69f4c913194db02a76b1a651d76c
Gerrit-Change-Number: 514880
Gerrit-PatchSet: 3
Gerrit-Owner: Tess Strickland <sstr...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 15:37:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tess Strickland (Gerrit)

unread,
Jun 19, 2026, 8:25:58 AM (5 days ago) Jun 19
to dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

Tess Strickland added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Tess Strickland . resolved

Just a note, the only "failures" in the dynamic trybots at this point are Crash -> RTE, because the crashes caused by the use of compound arguments/returns are now gone, exposing other unhandled features of the FFI library: callbacks or an appropriate bytecode implementation for Native._addressOf, so PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibeae6dc4213f69f4c913194db02a76b1a651d76c
    Gerrit-Change-Number: 514880
    Gerrit-PatchSet: 6
    Gerrit-Owner: Tess Strickland <sstr...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Tess Strickland <sstr...@google.com>
    Gerrit-Attention: Alexander Markov <alexm...@google.com>
    Gerrit-Comment-Date: Fri, 19 Jun 2026 12:25:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tess Strickland (Gerrit)

    unread,
    Jun 19, 2026, 10:42:54 AM (5 days ago) Jun 19
    to dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
    Attention needed from Alexander Markov

    Tess Strickland added 1 comment

    Patchset-level comments
    Tess Strickland . resolved

    Just a note, the only "failures" in the dynamic trybots at this point are Crash -> RTE, because the crashes caused by the use of compound arguments/returns are now gone, exposing other unhandled features of the FFI library: callbacks or an appropriate bytecode implementation for Native._addressOf, so PTAL.

    Tess Strickland

    Or not, since I noticed that I was handling the PointerToMemory case wrong and wasn't handling the single Stack case at all, so pulling this back until I fix things up appropriately.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexander Markov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibeae6dc4213f69f4c913194db02a76b1a651d76c
    Gerrit-Change-Number: 514880
    Gerrit-PatchSet: 7
    Gerrit-Owner: Tess Strickland <sstr...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Tess Strickland <sstr...@google.com>
    Gerrit-Attention: Alexander Markov <alexm...@google.com>
    Gerrit-Comment-Date: Fri, 19 Jun 2026 14:42:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Tess Strickland <sstr...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tess Strickland (Gerrit)

    unread,
    Jun 23, 2026, 12:50:29 PM (11 hours ago) Jun 23
    to dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
    Attention needed from Alexander Markov

    New activity on the change

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexander Markov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibeae6dc4213f69f4c913194db02a76b1a651d76c
    Gerrit-Change-Number: 514880
    Gerrit-PatchSet: 20
    Gerrit-Owner: Tess Strickland <sstr...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Tess Strickland <sstr...@google.com>
    Gerrit-Attention: Alexander Markov <alexm...@google.com>
    Gerrit-Comment-Date: Tue, 23 Jun 2026 16:50:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alexander Markov (Gerrit)

    unread,
    Jun 23, 2026, 3:01:47 PM (9 hours ago) Jun 23
    to Tess Strickland, Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
    Attention needed from Tess Strickland

    Alexander Markov voted and added 1 comment

    Votes added by Alexander Markov

    Code-Review+1

    1 comment

    File runtime/vm/runtime_entry.cc
    Line 1300, Patchset 20 (Latest): intptr_t arg_index,
    Alexander Markov . unresolved

    Nit: not used?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tess Strickland
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibeae6dc4213f69f4c913194db02a76b1a651d76c
    Gerrit-Change-Number: 514880
    Gerrit-PatchSet: 20
    Gerrit-Owner: Tess Strickland <sstr...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Tess Strickland <sstr...@google.com>
    Gerrit-Attention: Tess Strickland <sstr...@google.com>
    Gerrit-Comment-Date: Tue, 23 Jun 2026 19:01:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages