[XL] Change in dart/sdk[main]: [vm] Generate Dart declarations for runtime offsets
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Dec 9, 2025, 6:40:27 PM12/9/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Tess Strickland, Nate Biggs, Nicholas Shahan, Stephen Adams, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Dec 10, 2025, 8:21:15 AM12/10/25
to Alexander Markov, Alexander Aprelev, Tess Strickland, Nate Biggs, Nicholas Shahan, Stephen Adams, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov
Slava Egorov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Slava Egorov
| Code-Review | +1 |
1 comment
File pkg/native_compiler/lib/runtime/vm_offsets.g.dart
Line 14, Patchset 3 (Latest):
int get iCData_receivers_static_type_offset => throw 'Unknown';Slava Egorov . unresolved
This capitalization is a bit wild. ]
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 10, 2025, 9:31:26 AM12/10/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Tess Strickland, Nate Biggs, Nicholas Shahan, Stephen Adams, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov
Alexander Markov added 1 comment![]( "Open in Gerrit")
File pkg/native_compiler/lib/runtime/vm_offsets.g.dart
Line 14, Patchset 3 (Latest):
int get iCData_receivers_static_type_offset => throw 'Unknown';Slava Egorov . unresolved
This capitalization is a bit wild. ]
Alexander Markov
Would you prefer `ClassName_field_name` for these getters instead of `className_field_name`? We can probably also adjust C-style `field_name` to be `fieldName` but that would make it less searchable.
What would be the best naming here (based on the names from `runtime/vm/compiler/runtime_offsets_list.h`)?
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Dec 11, 2025, 3:22:14 AM12/11/25
to Alexander Markov, Alexander Aprelev, Tess Strickland, Nate Biggs, Nicholas Shahan, Stephen Adams, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov
Slava Egorov added 1 comment![]( "Open in Gerrit")
File pkg/native_compiler/lib/runtime/vm_offsets.g.dart
Line 14, Patchset 3 (Latest):
int get iCData_receivers_static_type_offset => throw 'Unknown';Slava Egorov . unresolved
Alexander MarkovThis capitalization is a bit wild. ]
Would you prefer `ClassName_field_name` for these getters instead of `className_field_name`? We can probably also adjust C-style `field_name` to be `fieldName` but that would make it less searchable.
What would be the best naming here (based on the names from `runtime/vm/compiler/runtime_offsets_list.h`)?
Slava Egorov
I think we should just keep the original capitalization and suppress lints. Because currently it is neither here nor there.
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 11, 2025, 10:53:35 AM12/11/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Tess Strickland, Nate Biggs, Nicholas Shahan, Stephen Adams, Commit Queue, rev...@dartlang.org
Alexander Markov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File pkg/native_compiler/lib/runtime/vm_offsets.g.dart
Line 14, Patchset 3:
int get iCData_receivers_static_type_offset => throw 'Unknown';Slava Egorov . resolved
Alexander MarkovThis capitalization is a bit wild. ]
Slava EgorovWould you prefer `ClassName_field_name` for these getters instead of `className_field_name`? We can probably also adjust C-style `field_name` to be `fieldName` but that would make it less searchable.
What would be the best naming here (based on the names from `runtime/vm/compiler/runtime_offsets_list.h`)?
I think we should just keep the original capitalization and suppress lints. Because currently it is neither here nor there.
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 11, 2025, 11:24:01 AM12/11/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Tess Strickland, Nate Biggs, Nicholas Shahan, Stephen Adams, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/run_offsets_extractor.dart
Insertions: 2, Deletions: 6.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/native_compiler/lib/runtime/vm_offsets.g.dart
Insertions: 1622, Deletions: 1622.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[vm] Generate Dart declarations for runtime offsets
TEST=dart tools/run_offsets_extractor.dart
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: Ic24111aa923214cfc332a8fb4677d8941a2999d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/446700
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- A pkg/native_compiler/lib/runtime/vm_offsets.g.dart
- M runtime/vm/compiler/offsets_extractor.cc
- M runtime/vm/compiler/runtime_api.cc
- M runtime/vm/compiler/runtime_offsets_list.h
- M runtime/vm/dart.cc
- M runtime/vm/runtime_entry.h
- M runtime/vm/stub_code.h
- M tools/run_offsets_extractor.dart
Change size: XL
Delta: 8 files changed, 2814 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages