[M] Change in dart/sdk[main]: [dart2wasm] Fix bug in handling of forwarding stubs to fields
0 views
Skip to first unread message
Martin Kustermann (Gerrit)
Feb 12, 2026, 9:18:22 AM (4 days ago) Feb 12
to Jonas Jensen, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Ömer Ağacan
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ömer Ağacan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Feb 13, 2026, 4:07:18 AM (4 days ago) Feb 13
to Jonas Jensen, Nate Biggs, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Jonas Jensen, Nate Biggs and Ömer Ağacan
Martin Kustermann added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Jonas Jensen
- Nate Biggs
- Ömer Ağacan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Feb 13, 2026, 11:30:48 AM (3 days ago) Feb 13
to Martin Kustermann, Jonas Jensen, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Jonas Jensen, Martin Kustermann and Ömer Ağacan
Nate Biggs voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nate Biggs
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jonas Jensen
- Martin Kustermann
- Ömer Ağacan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Feb 13, 2026, 2:16:23 PM (3 days ago) Feb 13
to Jonas Jensen, Nate Biggs, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Jonas Jensen and Ömer Ağacan
Martin Kustermann voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Jonas Jensen
- Ömer Ağacan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Feb 13, 2026, 2:57:01 PM (3 days ago) Feb 13
to Martin Kustermann, Jonas Jensen, Nate Biggs, Ömer Ağacan, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[dart2wasm] Fix bug in handling of forwarding stubs to fields
The CFE may insert forwarding stubs not only for procedures
but also for fields that require covariance type checks on
the setter values.
This also fixes a bug where type parameter bounds weren't
correctly type checked against (The VM has the same bug, see [1])
[0] https://github.com/dart-lang/sdk/issues/62664
Fixes https://github.com/dart-lang/sdk/issues/62662
Change-Id: I61c005a26bd393df3279fdb349304ccc1eec9c6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480200
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Martin Kustermann <kuste...@google.com>
Files:
- M pkg/dart2wasm/lib/code_generator.dart
- M pkg/dart2wasm/lib/translator.dart
- A tests/web/wasm/forwarding_stubs_regress_62662_test.dart
Change size: M
Delta: 3 files changed, 135 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Biggs
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages