[M] Change in dart/sdk[main]: [dart2wasm] Fix bug in handling of forwarding stubs to fields

0 views
Skip to first unread message

Martin Kustermann (Gerrit)

unread,
Feb 12, 2026, 9:18:22 AM (4 days ago) Feb 12
to Jonas Jensen, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Ömer Ağacan

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ömer Ağacan
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I61c005a26bd393df3279fdb349304ccc1eec9c6c
Gerrit-Change-Number: 480200
Gerrit-PatchSet: 5
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 14:18:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Martin Kustermann (Gerrit)

unread,
Feb 13, 2026, 4:07:18 AM (4 days ago) Feb 13
to Jonas Jensen, Nate Biggs, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Jonas Jensen, Nate Biggs and Ömer Ağacan

Martin Kustermann added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Martin Kustermann . resolved

Adding @nate...@google.com (as Omer is OOO next week)

Open in Gerrit

Related details

Attention is currently required from:
  • Jonas Jensen
  • Nate Biggs
  • Ömer Ağacan
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I61c005a26bd393df3279fdb349304ccc1eec9c6c
Gerrit-Change-Number: 480200
Gerrit-PatchSet: 6
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-CC: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Jonas Jensen <jon...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Fri, 13 Feb 2026 09:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Nate Biggs (Gerrit)

unread,
Feb 13, 2026, 11:30:48 AM (3 days ago) Feb 13
to Martin Kustermann, Jonas Jensen, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Jonas Jensen, Martin Kustermann and Ömer Ağacan

Nate Biggs voted and added 1 comment

Votes added by Nate Biggs

Code-Review+1

1 comment

Patchset-level comments
Nate Biggs . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jonas Jensen
  • Martin Kustermann
  • Ömer Ağacan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I61c005a26bd393df3279fdb349304ccc1eec9c6c
Gerrit-Change-Number: 480200
Gerrit-PatchSet: 6
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-CC: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Jonas Jensen <jon...@google.com>
Gerrit-Comment-Date: Fri, 13 Feb 2026 16:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Martin Kustermann (Gerrit)

unread,
Feb 13, 2026, 2:16:23 PM (3 days ago) Feb 13
to Jonas Jensen, Nate Biggs, Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Jonas Jensen and Ömer Ağacan

Martin Kustermann voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jonas Jensen
  • Ömer Ağacan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I61c005a26bd393df3279fdb349304ccc1eec9c6c
Gerrit-Change-Number: 480200
Gerrit-PatchSet: 6
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-CC: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Jonas Jensen <jon...@google.com>
Gerrit-Comment-Date: Fri, 13 Feb 2026 19:16:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Feb 13, 2026, 2:57:01 PM (3 days ago) Feb 13
to Martin Kustermann, Jonas Jensen, Nate Biggs, Ömer Ağacan, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[dart2wasm] Fix bug in handling of forwarding stubs to fields

The CFE may insert forwarding stubs not only for procedures
but also for fields that require covariance type checks on
the setter values.

This also fixes a bug where type parameter bounds weren't
correctly type checked against (The VM has the same bug, see [1])

[0] https://github.com/dart-lang/sdk/issues/62664

Fixes https://github.com/dart-lang/sdk/issues/62662
Change-Id: I61c005a26bd393df3279fdb349304ccc1eec9c6c
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Martin Kustermann <kuste...@google.com>
Files:
  • M pkg/dart2wasm/lib/code_generator.dart
  • M pkg/dart2wasm/lib/translator.dart
  • A tests/web/wasm/forwarding_stubs_regress_62662_test.dart
Change size: M
Delta: 3 files changed, 135 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Biggs
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I61c005a26bd393df3279fdb349304ccc1eec9c6c
Gerrit-Change-Number: 480200
Gerrit-PatchSet: 7
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-CC: Martin Kustermann <kuste...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages