Change in dart/sdk[master]: Re-enable the unnecessary_imports check
Samuel Rawlins (Gerrit)
Attention is currently required from: Konstantin Shcheglov, Brian Wilkerson.
Samuel Rawlins would like Konstantin Shcheglov and Brian Wilkerson to review this change.
Re-enable the unnecessary_imports check
Bug: https://github.com/flutter/flutter/issues/82844
Change-Id: Iaf7017578177952b4871e340b057c442be01bfd6
---
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
M pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
index 3cb56a5..73797af 100644
--- a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
@@ -299,9 +299,8 @@
verifier.generateDuplicateShownHiddenNameHints(errorReporter);
verifier.generateUnusedImportHints(errorReporter);
verifier.generateUnusedShownNameHints(errorReporter);
- // TODO(srawlins): Re-enable this check once Flutter engine path is clear.
- // verifier.generateUnnecessaryImportHints(
- // errorReporter, _usedImportedElementsList);
+ verifier.generateUnnecessaryImportHints(
+ errorReporter, _usedImportedElementsList);
}
// Unused local elements.
diff --git a/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart b/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
index a5c76d1..b6071fc 100644
--- a/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
+++ b/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
@@ -9,8 +9,7 @@
main() {
defineReflectiveSuite(() {
- // TODO(srawlins): Re-enable this check once Flutter engine path is clear.
- // defineReflectiveTests(UnnecessaryImportTest);
+ defineReflectiveTests(UnnecessaryImportTest);
});
}
To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.
Samuel Rawlins (Gerrit)
Attention is currently required from: Konstantin Shcheglov, Brian Wilkerson.
1 comment:
Patchset:
To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.
Konstantin Shcheglov (Gerrit)
Attention is currently required from: Samuel Rawlins, Brian Wilkerson.
Patch set 1:Code-Review +1
Brian Wilkerson (Gerrit)
Attention is currently required from: Samuel Rawlins.
Patch set 1:Code-Review +1
To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.
Dart CI (Gerrit)
go/dart-cbuild result: FAILURE (REGRESSIONS DETECTED)
Details: https://goto.google.com/dart-cbuild/find/0ec272b6e5b897f2e08e1c2d5f644e0ffb2a0618
Bugs: go/dart-cbuild-bug/0ec272b6e5b897f2e08e1c2d5f644e0ffb2a0618