[M] Change in dart/sdk[main]: Augment. Deprecate MethodDeclaration.isAbstract, add isComplete to Co...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Jun 8, 2026, 11:53:48 AM (4 days ago) Jun 8
to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry
Brian Wilkerson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
2 comments
Patchset-level comments
File pkg/analysis_server/lib/src/computer/computer_outline.dart
Line 451, Patchset 1 (Latest):
isAbstract: !method.isComplete,Brian Wilkerson . unresolved
This raises an interesting UX question.
I agree that we'll want to have outline entries for fragments in order to make it easier to navigate to a specific fragment. It's not clear to me whether we'll want to mark the fragments as being incomplete (because I don't know how useful that is for a user), continue to mark them as being abstract (presumably when the element defined by the fragments is incomplete?), or both.
Could you open an issue so that we don't forget to make a decision about this?
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jun 8, 2026, 11:57:05 AM (4 days ago) Jun 8
to Brian Wilkerson, Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
File pkg/analysis_server/lib/src/computer/computer_outline.dart
Line 451, Patchset 1 (Latest):
isAbstract: !method.isComplete,Brian Wilkerson . resolved
This raises an interesting UX question.
I agree that we'll want to have outline entries for fragments in order to make it easier to navigate to a specific fragment. It's not clear to me whether we'll want to mark the fragments as being incomplete (because I don't know how useful that is for a user), continue to mark them as being abstract (presumably when the element defined by the fragments is incomplete?), or both.
Could you open an issue so that we don't forget to make a decision about this?
Attention is currently required from:
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Jun 9, 2026, 3:58:46 AM (3 days ago) Jun 9
to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jun 9, 2026, 1:36:00 PM (3 days ago) Jun 9
to Johnni Winther, Brian Wilkerson, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jun 9, 2026, 1:40:32 PM (3 days ago) Jun 9
to Johnni Winther, Brian Wilkerson, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 2:28:29 PM (3 days ago) Jun 9
to Konstantin Shcheglov, Johnni Winther, Brian Wilkerson, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analyzer/CHANGELOG.md
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Augment. Deprecate MethodDeclaration.isAbstract, add isComplete to ConstructorDeclaration, FunctionDeclaration, MethodDeclaration.
Change-Id: I3d5c884870ef183f54e59cd0a5c735373cbe71a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509900
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/computer/computer_outline.dart
- M pkg/analyzer/CHANGELOG.md
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/src/dart/ast/ast.dart
- M pkg/analyzer/lib/src/error/annotation_verifier.dart
- M pkg/analyzer/lib/src/error/inheritance_override.dart
- M pkg/analyzer/lib/src/error/must_call_super_verifier.dart
- M pkg/analyzer/lib/src/generated/error_verifier.dart
- M pkg/analyzer/lib/src/summary2/element_builder.dart
Change size: M
Delta: 9 files changed, 39 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages