[L] Change in dart/sdk[main]: Ensure that default type of type parameters is not modified by augmen...

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Jun 19, 2026, 7:59:09 PM (4 days ago) Jun 19
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
Gerrit-Change-Number: 515420
Gerrit-PatchSet: 5
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Jun 2026 23:59:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Jun 19, 2026, 8:49:22 PM (4 days ago) Jun 19
to Fedor Shcheglov, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov and Johnni Winther

Konstantin Shcheglov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
Gerrit-Change-Number: 515420
Gerrit-PatchSet: 5
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Sat, 20 Jun 2026 00:49:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fedor Shcheglov (Gerrit)

unread,
Jun 21, 2026, 3:19:22 PM (2 days ago) Jun 21
to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Konstantin Shcheglov

Fedor Shcheglov added 1 comment

File pkg/analyzer/test/src/diagnostics/augmentation_type_parameter_count_test.dart
Line 39, Patchset 6 (Latest): defaultType: null
Fedor Shcheglov . unresolved

This is expected because `T` is a synthetic element and won't be used from outside as a value instead of an omitted type argument. We filter out the synthetic type parameters from `InstanceElement.typeParameters`.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
Gerrit-Change-Number: 515420
Gerrit-PatchSet: 6
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Sun, 21 Jun 2026 19:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Jun 21, 2026, 5:20:15 PM (2 days ago) Jun 21
to Fedor Shcheglov, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov and Johnni Winther

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
Gerrit-Change-Number: 515420
Gerrit-PatchSet: 6
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Sun, 21 Jun 2026 21:20:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Jun 22, 2026, 4:14:45 AM (2 days ago) Jun 22
to Fedor Shcheglov, Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Johnni Winther voted and added 1 comment

Votes added by Johnni Winther

Code-Review+1

1 comment

File pkg/analyzer/test/src/summary/elements/enum_test.dart
Line 14604, Patchset 6 (Parent): test_enum_typeParameters_defaultType() async {
var library = await buildLibrary(r'''
enum A<T extends B> {
v
}
class B {}

augment enum A<T extends B> {}
''');
Johnni Winther . unresolved

Do we test this elsewhere?

Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
    Gerrit-Change-Number: 515420
    Gerrit-PatchSet: 6
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 08:14:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Fedor Shcheglov (Gerrit)

    unread,
    Jun 22, 2026, 4:49:31 PM (2 days ago) Jun 22
    to Johnni Winther, Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Johnni Winther and Konstantin Shcheglov

    Fedor Shcheglov added 1 comment

    File pkg/analyzer/test/src/summary/elements/enum_test.dart
    Line 14604, Patchset 6 (Parent): test_enum_typeParameters_defaultType() async {
    var library = await buildLibrary(r'''
    enum A<T extends B> {
    v
    }
    class B {}

    augment enum A<T extends B> {}
    ''');
    Johnni Winther . unresolved

    Do we test this elsewhere?

    Fedor Shcheglov

    No, we replaced this test with `test_enum_typeParameters_augmentation_chain_bounds_int_string` which demonstrates an erroneous scenario, but we should probably add an `int_int` version as well, that demonstrates correct behavior.

    The current form of this test isn't ideal because it introduces an unnecessary class `B`. Despite the name claiming it checks default type, it doesn't actually print it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Johnni Winther
    • Konstantin Shcheglov
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
    Gerrit-Change-Number: 515420
    Gerrit-PatchSet: 7
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 20:49:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
    unsatisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Jun 22, 2026, 4:51:02 PM (2 days ago) Jun 22
    to Fedor Shcheglov, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov and Johnni Winther

    Konstantin Shcheglov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    • Johnni Winther
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
    Gerrit-Change-Number: 515420
    Gerrit-PatchSet: 7
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 20:50:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Paul Berry (Gerrit)

    unread,
    Jun 23, 2026, 6:36:30 PM (5 hours ago) Jun 23
    to Fedor Shcheglov, Konstantin Shcheglov, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov and Johnni Winther

    Paul Berry voted and added 1 comment

    Votes added by Paul Berry

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Paul Berry . resolved

    Changes from patchset 6-7 lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    • Johnni Winther
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
      Gerrit-Change-Number: 515420
      Gerrit-PatchSet: 7
      Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Reviewer: Paul Berry <paul...@google.com>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 22:36:27 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Konstantin Shcheglov (Gerrit)

      unread,
      Jun 23, 2026, 7:11:10 PM (5 hours ago) Jun 23
      to Fedor Shcheglov, Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
      Attention needed from Fedor Shcheglov and Johnni Winther

      Konstantin Shcheglov voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fedor Shcheglov
      • Johnni Winther
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
      Gerrit-Change-Number: 515420
      Gerrit-PatchSet: 7
      Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Reviewer: Paul Berry <paul...@google.com>
      Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
      Gerrit-Attention: Johnni Winther <johnni...@google.com>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 23:11:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Konstantin Shcheglov (Gerrit)

      unread,
      Jun 23, 2026, 9:53:42 PM (2 hours ago) Jun 23
      to Fedor Shcheglov, Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
      Gerrit-Comment-Date: Wed, 24 Jun 2026 01:53:36 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

      unread,
      Jun 23, 2026, 10:11:59 PM (2 hours ago) Jun 23
      to Fedor Shcheglov, Paul Berry, Konstantin Shcheglov, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org

      dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

      Change information

      Commit message:
      Ensure that default type of type parameters is not modified by augmentations.
      Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
      Reviewed-by: Konstantin Shcheglov <sche...@google.com>
      Commit-Queue: Konstantin Shcheglov <sche...@google.com>
      Reviewed-by: Paul Berry <paul...@google.com>
      Files:
      • M pkg/analyzer/lib/src/summary2/default_types_builder.dart
      • M pkg/analyzer/test/src/diagnostics/augmentation_type_parameter_count_test.dart
      • M pkg/analyzer/test/src/summary/element_text.dart
      • M pkg/analyzer/test/src/summary/elements/class_test.dart
      • M pkg/analyzer/test/src/summary/elements/enum_test.dart
      • M pkg/analyzer/test/src/summary/elements/extension_type_test.dart
      • M pkg/analyzer/test/src/summary/elements/top_level_function_test.dart
      Change size: L
      Delta: 7 files changed, 476 insertions(+), 264 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Paul Berry
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: Icd71fc867a3741e8b97d27b18e6adbfeb6e5bfc9
      Gerrit-Change-Number: 515420
      Gerrit-PatchSet: 8
      Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Reviewer: Paul Berry <paul...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages