[M] Change in dart/sdk[main]: linter: Refactor flutter utils
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Jan 9, 2026, 10:54:26 AM (2 days ago) Jan 9
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jan 9, 2026, 12:47:28 PM (2 days ago) Jan 9
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 9, 2026, 12:47:43 PM (2 days ago) Jan 9
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
linter: Refactor flutter utils
Previously, this library was a handfful of top-level functions, which
all deferred to instance methods on a static instance of _Flutter. But this instance of _Flutter was also perfectly static, only instantiated one time, with constant strings as constructor arguments.
So I moved each instance method to the outer public function that called
it, and inlined flutter package URLs.
(These URLs will not change with Featherlight; none are concerned with
material or cupertino.)
Some methods were unused, like `hasWidgetAsAscendant`, so I deleted
them.
Change-Id: Iddbd177965491e47e61a7655fe0679b826f82535
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/471641
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/linter/lib/src/rules/no_logic_in_create_state.dart
- M pkg/linter/lib/src/util/flutter_utils.dart
Change size: M
Delta: 2 files changed, 45 insertions(+), 116 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages