[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. A-B.
0 views
Skip to first unread message
Johnni Winther (Gerrit)
May 11, 2026, 3:11:39 AM (2 days ago) May 11
to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johnni Winther
| Code-Review | +1 |
1 comment
File pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
Line 635, Patchset 1 (Latest):
// [diag.argumentTypeNotAssignable] The argument type 'String' can't be assigned to the parameter type 'int'. Johnni Winther . unresolved
Why do we sometimes have trailing whitespace?
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
May 11, 2026, 11:50:43 AM (2 days ago) May 11
to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
File pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
Line 635, Patchset 1 (Latest):
// [diag.argumentTypeNotAssignable] The argument type 'String' can't be assigned to the parameter type 'int'. Johnni Winther . unresolved
Why do we sometimes have trailing whitespace?
Konstantin Shcheglov
```
argumentTypeNotAssignable:
type: compileTimeError
parameters:
Type actualStaticType: the name of the actual argument type
Type expectedStaticType: the name of the expected type
String additionalInfo: additional information, if any, when problem is associated with records
problemMessage: "The argument type '#actualStaticType' can't be assigned to the parameter type '#expectedStaticType'. #additionalInfo"
```
We probably should trim the error message.
I will do this separately.
Related details
Attention is currently required from:
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
May 12, 2026, 3:44:39 PM (17 hours ago) May 12
to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 12, 2026, 4:16:46 PM (17 hours ago) May 12
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. A-B.
Change-Id: I260150562d253f480f70f04b7038fc7bcdadca26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/501764
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/test/src/dart/resolution/node_text_expectations.dart
- M pkg/analyzer/test/src/dart/resolution/resolution.dart
- M pkg/analyzer/test/src/diagnostics/abi_specific_integer_mapping_test.dart
- M pkg/analyzer/test/src/diagnostics/abstract_class_member_test.dart
- M pkg/analyzer/test/src/diagnostics/abstract_field_constructor_initializer_test.dart
- M pkg/analyzer/test/src/diagnostics/abstract_field_initializer_test.dart
- M pkg/analyzer/test/src/diagnostics/abstract_super_member_reference_test.dart
- M pkg/analyzer/test/src/diagnostics/ambiguous_export_test.dart
- M pkg/analyzer/test/src/diagnostics/ambiguous_extension_member_access_test.dart
- M pkg/analyzer/test/src/diagnostics/ambiguous_import_test.dart
- M pkg/analyzer/test/src/diagnostics/ambiguous_set_or_map_literal_test.dart
- M pkg/analyzer/test/src/diagnostics/annotation_on_pointer_field_test.dart
- M pkg/analyzer/test/src/diagnostics/annotation_syntax_test.dart
- M pkg/analyzer/test/src/diagnostics/argument_must_be_a_constant_test.dart
- M pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
- M pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_to_error_handler_test.dart
- M pkg/analyzer/test/src/diagnostics/assert_in_redirecting_constructor_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_of_do_not_store_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_const_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_final_local_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_final_no_setter_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_final_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_function_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_method_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_primary_constructor_parameter_test.dart
- M pkg/analyzer/test/src/diagnostics/assignment_to_type_test.dart
- M pkg/analyzer/test/src/diagnostics/async_for_in_wrong_context_test.dart
- M pkg/analyzer/test/src/diagnostics/async_keyword_used_as_identifier_test.dart
- M pkg/analyzer/test/src/diagnostics/augmentation_of_different_declaration_kind_test.dart
- M pkg/analyzer/test/src/diagnostics/augmentation_of_mixin_application_class_test.dart
- M pkg/analyzer/test/src/diagnostics/augmentation_type_parameter_bound_test.dart
- M pkg/analyzer/test/src/diagnostics/augmentation_type_parameter_count_test.dart
- M pkg/analyzer/test/src/diagnostics/augmentation_type_parameter_name_test.dart
- M pkg/analyzer/test/src/diagnostics/augmentation_without_declaration_test.dart
- M pkg/analyzer/test/src/diagnostics/await_in_late_local_variable_initializer_test.dart
- M pkg/analyzer/test/src/diagnostics/await_in_wrong_context_test.dart
- M pkg/analyzer/test/src/diagnostics/await_of_incompatible_type_test.dart
- M pkg/analyzer/test/src/diagnostics/base_class_implemented_outside_of_library_test.dart
- M pkg/analyzer/test/src/diagnostics/base_mixin_implemented_outside_of_library_test.dart
- M pkg/analyzer/test/src/diagnostics/binary_operator_written_out_test.dart
- M pkg/analyzer/test/src/diagnostics/body_might_complete_normally_catch_error_test.dart
- M pkg/analyzer/test/src/diagnostics/body_might_complete_normally_nullable_test.dart
- M pkg/analyzer/test/src/diagnostics/body_might_complete_normally_test.dart
- M pkg/analyzer/test/src/diagnostics/break_label_on_switch_member_test.dart
- M pkg/analyzer/test/src/diagnostics/built_in_identifier_as_extension_name_test.dart
- M pkg/analyzer/test/src/diagnostics/built_in_identifier_as_extension_type_name_test.dart
- M pkg/analyzer/test/src/diagnostics/built_in_identifier_as_prefix_name_test.dart
- M pkg/analyzer/test/src/diagnostics/built_in_identifier_as_type_name_test.dart
- M pkg/analyzer/test/src/diagnostics/built_in_identifier_as_type_parameter_name_test.dart
- M pkg/analyzer/test/src/diagnostics/built_in_identifier_as_typedef_name_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_definition_test.dart
Change size: XL
Delta: 51 files changed, 4166 insertions(+), 6127 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages