[M] Change in dart/sdk[main]: [CFE] Incremental compiler test for flutter issue 178740

0 views
Skip to first unread message

Jens Johansen (Gerrit)

unread,
Dec 9, 2025, 2:15:08 AM12/9/25
to Slava Egorov, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Slava Egorov

Jens Johansen added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jens Johansen . resolved

Sending to Slava because he requested this test.

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9a68d1971972c82eb3ba30fe2efc4200239b2760
Gerrit-Change-Number: 466740
Gerrit-PatchSet: 2
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 07:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
Dec 10, 2025, 7:54:44 AM12/10/25
to Jens Johansen, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Jens Johansen

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jens Johansen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9a68d1971972c82eb3ba30fe2efc4200239b2760
Gerrit-Change-Number: 466740
Gerrit-PatchSet: 2
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 12:54:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jens Johansen (Gerrit)

unread,
Dec 10, 2025, 7:55:20 AM12/10/25
to Slava Egorov, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org

Jens Johansen voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9a68d1971972c82eb3ba30fe2efc4200239b2760
Gerrit-Change-Number: 466740
Gerrit-PatchSet: 2
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 12:55:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 10, 2025, 8:29:58 AM12/10/25
to Jens Johansen, Slava Egorov, dart-fe-te...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[CFE] Incremental compiler test for flutter issue 178740

The issue was fixed with
https://dart-review.googlesource.com/c/sdk/+/464380, but a different
test was requested in
https://github.com/flutter/flutter/issues/178740#issuecomment-3611849787
so here we are.
Change-Id: I9a68d1971972c82eb3ba30fe2efc4200239b2760
Commit-Queue: Jens Johansen <je...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
  • A pkg/front_end/testcases/incremental/flutter_issue_178740.yaml
  • A pkg/front_end/testcases/incremental/flutter_issue_178740.yaml.world.1.expect
  • A pkg/front_end/testcases/incremental/flutter_issue_178740.yaml.world.1.expression.1.expect
  • A pkg/front_end/testcases/incremental/flutter_issue_178740.yaml.world.2.expect
  • A pkg/front_end/testcases/incremental/flutter_issue_178740.yaml.world.2.expression.1.expect
Change size: M
Delta: 5 files changed, 85 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9a68d1971972c82eb3ba30fe2efc4200239b2760
Gerrit-Change-Number: 466740
Gerrit-PatchSet: 3
Gerrit-Owner: Jens Johansen <je...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages