[L] Change in dart/sdk[main]: [dart2wasm] Make IR tests more stable
Martin Kustermann (Gerrit)
Martin Kustermann added 1 comment![]( "Open in Gerrit")
(type $type234 <...>)These numbers were often changing which made us need to re-generate the expectation files.
Related details
- Ömer Ağacan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ömer Ağacan (Gerrit)
Ömer Ağacan voted and added 4 comments![]( "Open in Gerrit")
Votes added by Ömer Ağacan
| Code-Review | +1 |
4 comments
if (output == '-') {This is different than the documentation which says by default we print to stdout.
One of them should be updated. I suggest we update this line and print to stdout when output is not provided. Because otherwise the default doesn't do anything, and I doubt you ever run this program to do nothing.
help: 'Print functions/types/... in sorted order (sort by name).')Why not print sorted all the time? Is there a case where we don't want to sort?
'The filepath where the output will be written to (default: stdout). 'I don't think the default is right. It doesn't do anything when I don't pass `-o`. I tried this:
```
$ dart pkg/dart2wasm/bin/wasm2wat.dart /usr/local/google/home/omersa/dart/sdk/test/test.wasm
```
Which doesn't print anything.
'If omitted will write `<inpput.wasm>.wat` files.');inpput -> input
Related details
- Martin Kustermann
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Martin Kustermann added 6 comments![]( "Open in Gerrit")
This is different than the documentation which says by default we print to stdout.
One of them should be updated. I suggest we update this line and print to stdout when output is not provided. Because otherwise the default doesn't do anything, and I doubt you ever run this program to do nothing.
Okay, I've redone this now a bit differently and put my new use case under a `--write` flag.
help: 'Print functions/types/... in sorted order (sort by name).')Why not print sorted all the time? Is there a case where we don't want to sort?
Well, there's advantages to be able to dump the wasm file as text without real loss of information - so one can see e.g. if a new binaryen version reorders things.
In our IR tests specifically we're not interested in this and care more about stability of the text.
Since it's easy to have both options, I thought why not allow both.
'The filepath where the output will be written to (default: stdout). 'I don't think the default is right. It doesn't do anything when I don't pass `-o`. I tried this:
```
$ dart pkg/dart2wasm/bin/wasm2wat.dart /usr/local/google/home/omersa/dart/sdk/test/test.wasm
```
Which doesn't print anything.
It does print something into `test.wasm.wat`.
So the reason I did this change is
- almost always I use this tool to dump to file (very rarely to stdout)
- it's annoying to always having to supply `-o outputfile.wat`
- => with this CL a `dart wasm2wat.dart foo.wasm` will automatically write to `foo.wasm.wat`
- often I have two wasm files and I want to compare them: I don't want to run this tool twice, so I want `dart -s -f <some-filter> wasm2wat {before,after}.wasm && nvim -d {before,after}.wasm.wat`
I've done it now differently, this is now the supported usage pattern
- `dart wasm2wat.dart input.wasm` - to stdout
- `dart wasm2wat.dart input.wasm -o output.wat` - to `output.wat`
- `dart wasm2wat.dart -w input1.wasm input2.wasm ...` - to `input1.wasm.wat1`, `input2.wasm.wat`, ...
'If omitted will write `<inpput.wasm>.wat` files.');Martin Kustermanninpput -> input
Done
(type $type234 <...>)These numbers were often changing which made us need to re-generate the expectation files.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Martin Kustermann voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/dart2wasm/bin/wasm2wat.dart
Insertions: 28, Deletions: 11.
The diff is too large to show. Please review the diff.
```
Change information
[dart2wasm] Make IR tests more stable
To avoid depending on exact ordering binaryen uses in the wasm module,
we start
* enqueue functions/types/... based on sort name instead of index
in wasm module
* only assign increasing ids in `Namer` if we actually want to print
the name
* print functions/types/... in sorted order
for IR tests.
We also update the `pkg/dart2wasm/bin/wasm2wat.dart` tool to be
able to dump wat for multiple wasm modules.
- M pkg/dart2wasm/bin/wasm2wat.dart
- M pkg/dart2wasm/test/ir_test.dart
- M pkg/dart2wasm/test/ir_tests/deferred.constant.multi_module_use.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.multi_module_use_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.multi_module_use_module3.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant_module2.wat
- M pkg/dart2wasm/test/ir_tests/dyn_closure.wat
- M pkg/dart2wasm/test/ir_tests/dyn_closure_function_apply.wat
- M pkg/dart2wasm/test/ir_tests/dyn_closure_function_apply_named.wat
- M pkg/dart2wasm/test/ir_tests/import_name.wat
- M pkg/dart2wasm/test/ir_tests/interop.bool.wat
- M pkg/dart2wasm/test/ir_tests/interop.double.wat
- M pkg/dart2wasm/test/ir_tests/interop.int.wat
- M pkg/dart2wasm/test/ir_tests/interop.num.wat
- M pkg/dart2wasm/test/ir_tests/interop.string.wat
- M pkg/wasm_builder/lib/src/ir/module.dart
- M pkg/wasm_builder/lib/src/serialize/printer.dart
Code-Review: +1 by Ömer Ağacan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |