[M] Change in dart/sdk[main]: [analyzer_testing] Duplicates `ExpectedContextMessage` to start migra...

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Sep 25, 2025, 12:48:02 PM (4 days ago) Sep 25
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[analyzer_testing] Duplicates `ExpectedContextMessage` to start migrating

This is a first step towards migrating and merging tests helper classes to one central location. In a following CL, the old `ExpectedContextMessage` will be removed and all clients will be migrated to the new one.
Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88

Change information

Files:
  • M pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart
  • M pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart
Change size: M
Delta: 2 files changed, 141 insertions(+), 23 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88
Gerrit-Change-Number: 451542
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Paul Berry (Gerrit)

unread,
Sep 25, 2025, 3:40:46 PM (4 days ago) Sep 25
to Felipe Morschel, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Konstantin Shcheglov

Paul Berry voted and added 1 comment

Votes added by Paul Berry

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Paul Berry . resolved

lgtm.

+Konstantin, who I believe was responsible for adding a lot of this infrastructure in the first place.

Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
  • Konstantin Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88
Gerrit-Change-Number: 451542
Gerrit-PatchSet: 2
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 19:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Sep 25, 2025, 3:44:43 PM (4 days ago) Sep 25
to Felipe Morschel, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Konstantin Shcheglov voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88
    Gerrit-Change-Number: 451542
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 19:44:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Felipe Morschel (Gerrit)

    unread,
    Sep 25, 2025, 4:15:25 PM (4 days ago) Sep 25
    to Commit Queue, Konstantin Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Konstantin Shcheglov and Paul Berry

    Felipe Morschel voted and added 1 comment

    Votes added by Felipe Morschel

    Auto-Submit+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2:
    Felipe Morschel . resolved

    I always forget to generate `api.txt`, sorry! Fixed, thanks for the bots and reviews!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Konstantin Shcheglov
    • Paul Berry
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88
    Gerrit-Change-Number: 451542
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 20:15:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Sep 25, 2025, 4:16:20 PM (4 days ago) Sep 25
    to Felipe Morschel, Commit Queue, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Felipe Morschel and Paul Berry

    Konstantin Shcheglov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Felipe Morschel
    • Paul Berry
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88
    Gerrit-Change-Number: 451542
    Gerrit-PatchSet: 3
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 20:16:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Paul Berry (Gerrit)

    unread,
    Sep 26, 2025, 3:21:02 PM (3 days ago) Sep 26
    to Felipe Morschel, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Felipe Morschel

    Paul Berry voted and added 1 comment

    Votes added by Paul Berry

    Code-Review+1
    Commit-Queue+2

    1 comment

    Patchset-level comments
    Paul Berry . resolved

    lgtm

    Related details

    Attention is currently required from:
    • Felipe Morschel
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88
      Gerrit-Change-Number: 451542
      Gerrit-PatchSet: 3
      Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Reviewer: Paul Berry <paul...@google.com>
      Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Comment-Date: Fri, 26 Sep 2025 19:20:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Commit Queue (Gerrit)

      unread,
      Sep 26, 2025, 3:48:33 PM (3 days ago) Sep 26
      to Felipe Morschel, Paul Berry, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org

      Commit Queue submitted the change

      Change information

      Commit message:
      [analyzer_testing] Duplicates `ExpectedContextMessage` to start migrating

      This is a first step towards migrating and merging tests helper classes to one central location. In a following CL, the old `ExpectedError` and `ExpectedContextMessage` will be removed and all clients will be migrated to the version under this package.
      Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88
      Commit-Queue: Paul Berry <paul...@google.com>
      Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
      Reviewed-by: Paul Berry <paul...@google.com>
      Reviewed-by: Konstantin Shcheglov <sche...@google.com>
      Files:
      • M pkg/analyzer_testing/api.txt
      • M pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart
      • M pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart
      Change size: M
      Delta: 3 files changed, 145 insertions(+), 25 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Paul Berry
       Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: merged 
      

       Gerrit-Project: sdk 
      

       Gerrit-Branch: main 
      

       Gerrit-Change-Id: I7fb8a83cbd659192a22848ace99ebafed5dc2b88 
      

       Gerrit-Change-Number: 451542 
      

       Gerrit-PatchSet: 4 
      

       Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev> 
      

      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages