[S] Change in dart/sdk[main]: [vm] Disable ASAN/MSAN instrumentation in the inner marking loop.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Jan 21, 2026, 5:31:35 PM (7 hours ago) Jan 21
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
Ryan Macnak voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Jan 21, 2026, 5:32:50 PM (7 hours ago) Jan 21
to Ryan Macnak, Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jan 21, 2026, 5:33:36 PM (7 hours ago) Jan 21
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 21, 2026, 5:33:54 PM (7 hours ago) Jan 21
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Disable ASAN/MSAN instrumentation in the inner marking loop.
This doesn't provide much useful information for GC bugs but it is high fraction of program time in GC heavy runs.
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/62457
Change-Id: I4e62d6a64ca4ae8b492de3982981e6bfb053f9b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/474765
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
- M runtime/vm/bitfield.h
- M runtime/vm/heap/marker.cc
- M runtime/vm/raw_object.h
Change size: S
Delta: 3 files changed, 7 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages