[XL] Change in dart/sdk[main]: [dwds_test_common] Migrate package to the SDK repository

0 views
Skip to first unread message

Nicholas Shahan (Gerrit)

unread,
Mar 13, 2026, 4:48:48 PMMar 13
to Jessy Yameogo, Mark Zhou, Ben Konyi, rev...@dartlang.org
Attention needed from Ben Konyi, Jessy Yameogo and Mark Zhou

Nicholas Shahan added 2 comments

Patchset-level comments
File-level comment, Patchset 15 (Latest):
Nicholas Shahan . unresolved

Are we expecting any tests to run on the trybots showing green on this CL? I spot checked a few because I was curious what is running and didn't see any new test results.

File tools/VERSION
Line 25, Patchset 15 (Latest):#
Nicholas Shahan . unresolved

I've not familiar with making edits to this file. Why do we need this?

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
  • Jessy Yameogo
  • Mark Zhou
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7361a6dae11efcae72dd40630b4911ac1872f8b3
Gerrit-Change-Number: 487260
Gerrit-PatchSet: 15
Gerrit-Owner: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Attention: Mark Zhou <mark...@google.com>
Gerrit-Attention: Jessy Yameogo <yje...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 20:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Jessy Yameogo (Gerrit)

unread,
Mar 16, 2026, 4:30:15 PMMar 16
to Mark Zhou, Ben Konyi, Nicholas Shahan, rev...@dartlang.org
Attention needed from Ben Konyi, Mark Zhou and Nicholas Shahan

Jessy Yameogo added 2 comments

Patchset-level comments
Nicholas Shahan . unresolved

Are we expecting any tests to run on the trybots showing green on this CL? I spot checked a few because I was curious what is running and didn't see any new test results.

Jessy Yameogo

Currently, none of the new tests are running because this package depends on DWDS, which hasn't been migrated yet.

The strategy is to keep the migration manageable by splitting it into separate, smaller CLs rather than one massive change. This specific CL won't be submitted as-is; instead, I’m creating child CLs for the other components so they can be reviewed independently. Once the DWDS migration is ready in a follow-up CL, we’ll be able to see the test results greening up on the trybots. I plan to land all related parts simultaneously once the full migration is complete.

File tools/VERSION
Nicholas Shahan . resolved

I've not familiar with making edits to this file. Why do we need this?

Jessy Yameogo

hmm strange, thanks for catching this. I'm not sure why this change was made.. likely it happened when I rebuilt my sdk.... Will revert the change.

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
  • Mark Zhou
  • Nicholas Shahan
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7361a6dae11efcae72dd40630b4911ac1872f8b3
Gerrit-Change-Number: 487260
Gerrit-PatchSet: 15
Gerrit-Owner: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Attention: Mark Zhou <mark...@google.com>
Gerrit-Attention: Nicholas Shahan <nsh...@google.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 20:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Shahan <nsh...@google.com>
unsatisfied_requirement
open
diffy

Oscar García Pineda (Gerrit)

unread,
Mar 28, 2026, 1:05:07 AM (3 days ago) Mar 28
to Jessy Yameogo, Mark Zhou, Ben Konyi, Nicholas Shahan, rev...@dartlang.org
Attention needed from Ben Konyi, Jessy Yameogo, Mark Zhou and Nicholas Shahan

Oscar García Pineda added 1 comment

Patchset-level comments
File-level comment, Patchset 19 (Latest):
Oscar García Pineda . resolved

PARTNER layer 0 I am the one who accepts

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
  • Jessy Yameogo
  • Mark Zhou
  • Nicholas Shahan
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7361a6dae11efcae72dd40630b4911ac1872f8b3
Gerrit-Change-Number: 487260
Gerrit-PatchSet: 19
Gerrit-Owner: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-Reviewer: Oscar García Pineda <oscarp...@gmail.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Attention: Mark Zhou <mark...@google.com>
Gerrit-Attention: Jessy Yameogo <yje...@google.com>
Gerrit-Attention: Nicholas Shahan <nsh...@google.com>
Gerrit-Comment-Date: Sat, 28 Mar 2026 05:05:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages