[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Sort members in internal/external_ast_helper

0 views
Skip to first unread message

Chloe Stefantsova (Gerrit)

unread,
5:27 AM (4 hours ago) 5:27 AM
to Johnni Winther, Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I43151f2ec03298059ce7ffc7f034173c9f0a582c
Gerrit-Change-Number: 503320
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 09:27:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
5:51 AM (3 hours ago) 5:51 AM
to Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org

Johnni Winther voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I43151f2ec03298059ce7ffc7f034173c9f0a582c
Gerrit-Change-Number: 503320
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 09:50:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
7:10 AM (2 hours ago) 7:10 AM
to Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Wed, 13 May 2026 11:10:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
7:21 AM (2 hours ago) 7:21 AM
to Johnni Winther, Chloe Stefantsova, dart-fe-te...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[cfe][InternalNodes] Sort members in internal/external_ast_helper
Change-Id: I43151f2ec03298059ce7ffc7f034173c9f0a582c
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>
Commit-Queue: Johnni Winther <johnni...@google.com>
Files:
  • M pkg/front_end/lib/src/kernel/external_ast_helper.dart
  • M pkg/front_end/lib/src/kernel/internal_ast_helper.dart
Change size: XL
Delta: 2 files changed, 1649 insertions(+), 1649 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Chloe Stefantsova
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I43151f2ec03298059ce7ffc7f034173c9f0a582c
Gerrit-Change-Number: 503320
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages