[S] Change in dart/sdk[main]: [vm, dynamic_modules] Support loading of dynamic modules from unmodif...

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Nov 6, 2024, 1:03:40 PM11/6/24
to Alexander Markov, Slava Egorov, Sigmund Cherem, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Sigmund Cherem and Slava Egorov

Alexander Markov added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alexander Markov . resolved

PTAL

I (pre-)approved failure of the new test on DDC on Windows with https://github.com/dart-lang/sdk/issues/56725.

Open in Gerrit

Related details

Attention is currently required from:
  • Sigmund Cherem
  • Slava Egorov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I5b04acd458da437b6ce4cf4b36e0c60c3d3458aa
Gerrit-Change-Number: 393920
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Sigmund Cherem <sig...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Attention: Sigmund Cherem <sig...@google.com>
Gerrit-Comment-Date: Wed, 06 Nov 2024 18:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
Nov 6, 2024, 2:43:35 PM11/6/24
to Alexander Markov, Sigmund Cherem, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov and Sigmund Cherem

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
  • Sigmund Cherem
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I5b04acd458da437b6ce4cf4b36e0c60c3d3458aa
Gerrit-Change-Number: 393920
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Sigmund Cherem <sig...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Sigmund Cherem <sig...@google.com>
Gerrit-Comment-Date: Wed, 06 Nov 2024 19:43:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sigmund Cherem (Gerrit)

unread,
Nov 6, 2024, 3:22:41 PM11/6/24
to Alexander Markov, Sigmund Cherem, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

Sigmund Cherem voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I5b04acd458da437b6ce4cf4b36e0c60c3d3458aa
Gerrit-Change-Number: 393920
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Sigmund Cherem <sig...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Wed, 06 Nov 2024 20:22:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
Nov 6, 2024, 3:23:46 PM11/6/24
to Alexander Markov, Sigmund Cherem, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org

Alexander Markov voted and added 1 comment

Votes added by Alexander Markov

Commit-Queue+2

1 comment

Patchset-level comments
Alexander Markov . resolved

Thank you both for taking a look!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I5b04acd458da437b6ce4cf4b36e0c60c3d3458aa
Gerrit-Change-Number: 393920
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Sigmund Cherem <sig...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Wed, 06 Nov 2024 20:23:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Nov 6, 2024, 3:24:02 PM11/6/24
to Alexander Markov, Sigmund Cherem, Slava Egorov, rev...@dartlang.org, vm-...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[vm, dynamic_modules] Support loading of dynamic modules from unmodifiable view

TEST=pkg/dynamic_modules/test/data/load_unmodifiable_view
Fixes https://github.com/dart-lang/sdk/issues/57039
Change-Id: I5b04acd458da437b6ce4cf4b36e0c60c3d3458aa
Reviewed-by: Sigmund Cherem <sig...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
  • M pkg/dynamic_modules/test/common/testing.dart
  • A pkg/dynamic_modules/test/data/load_unmodifiable_view/dynamic_interface.yaml
  • A pkg/dynamic_modules/test/data/load_unmodifiable_view/main.dart
  • A pkg/dynamic_modules/test/data/load_unmodifiable_view/modules/entry1.dart
  • M runtime/lib/object.cc
Change size: S
Delta: 5 files changed, 46 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sigmund Cherem, +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I5b04acd458da437b6ce4cf4b36e0c60c3d3458aa
Gerrit-Change-Number: 393920
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages