[S] Change in dart/sdk[main]: [vm, dynamic_modules] Support loading of dynamic modules from unmodif...
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Nov 6, 2024, 1:03:40 PM11/6/24
to Alexander Markov, Slava Egorov, Sigmund Cherem, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Sigmund Cherem and Slava Egorov
Alexander Markov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alexander Markov . resolved
PTAL
I (pre-)approved failure of the new test on DDC on Windows with https://github.com/dart-lang/sdk/issues/56725.
Related details
Attention is currently required from:
- Sigmund Cherem
- Slava Egorov
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Nov 6, 2024, 2:43:35 PM11/6/24
to Alexander Markov, Sigmund Cherem, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov and Sigmund Cherem
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Markov
- Sigmund Cherem
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sigmund Cherem (Gerrit)
Nov 6, 2024, 3:22:41 PM11/6/24
to Alexander Markov, Sigmund Cherem, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Sigmund Cherem voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Nov 6, 2024, 3:23:46 PM11/6/24
to Alexander Markov, Sigmund Cherem, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Alexander Markov . resolved
Thank you both for taking a look!
Related details
Attention set is empty
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Nov 6, 2024, 3:24:02 PM11/6/24
to Alexander Markov, Sigmund Cherem, Slava Egorov, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm, dynamic_modules] Support loading of dynamic modules from unmodifiable view
TEST=pkg/dynamic_modules/test/data/load_unmodifiable_view
Fixes https://github.com/dart-lang/sdk/issues/57039
Change-Id: I5b04acd458da437b6ce4cf4b36e0c60c3d3458aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393920
Reviewed-by: Sigmund Cherem <sig...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
- M pkg/dynamic_modules/test/common/testing.dart
- A pkg/dynamic_modules/test/data/load_unmodifiable_view/dynamic_interface.yaml
- A pkg/dynamic_modules/test/data/load_unmodifiable_view/main.dart
- A pkg/dynamic_modules/test/data/load_unmodifiable_view/modules/entry1.dart
- M runtime/lib/object.cc
Change size: S
Delta: 5 files changed, 46 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sigmund Cherem, +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages