[M] Change in dart/sdk[main]: [cfe] Produce synthetic assignments in for-in loops in output form
0 views
Skip to first unread message
Chloe Stefantsova (Gerrit)
Mar 13, 2026, 10:44:03 AMMar 13
to Chloe Stefantsova, Commit Queue, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Chloe Stefantsova added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Chloe Stefantsova . resolved
Johnni, Alex, PTAL. For the redness on the bot vm-dyn-mac-debug-arm64-try, I'm not sure my CL is the cause of the failures. Please share if you have more insight into it.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Mar 13, 2026, 3:15:13 PMMar 13
to Chloe Stefantsova, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Code-Review | +1 |
1 comment
Patchset-level comments
Chloe Stefantsova . resolved
Johnni, Alex, PTAL. For the redness on the bot vm-dyn-mac-debug-arm64-try, I'm not sure my CL is the cause of the failures. Please share if you have more insight into it.
Alexander Markov
The failures are the new tests after co19 roll (`new test -> CompileTimeError`). They are also failing on other bots and those failures are approved, so they are not related to this CL. You can also rerun the red bot after corresponding nightly bot cycles on the CI (e.g. tomorrow) and they should disappear.
Related details
Attention is currently required from:
- Chloe Stefantsova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chloe Stefantsova (Gerrit)
Mar 16, 2026, 4:12:24 AMMar 16
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Chloe Stefantsova voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Mar 16, 2026, 5:24:30 AMMar 16
to Chloe Stefantsova, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Chloe Stefantsova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chloe Stefantsova (Gerrit)
Mar 16, 2026, 5:48:12 AMMar 16
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Chloe Stefantsova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Chloe Stefantsova
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Chloe Stefantsova . resolved
Thank you for the review and the discussion, Johnni and Alex!
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chloe Stefantsova (Gerrit)
Mar 16, 2026, 6:39:19 AMMar 16
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Chloe Stefantsova voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 16, 2026, 6:50:40 AMMar 16
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/dart2bytecode/test/bytecode_generator_test.dart
Insertions: 0, Deletions: 8.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[cfe] Produce synthetic assignments in for-in loops in output form
In the new variable encoding, variables exist either in the internal
form (InternalLocalVariable, InternalSyntheticVariable, etc) or in the
output form, which is passed to the backends. Normally, type inference
is the mechanism that consumes the variables in the internal forma and
produces the variables in the output form. However, some expressions are
produced before type inference (in the BodyBuilder) and will never be
processed by type inference. Synthetic assignments in for-in loops is an
example of such expressions.
This CL modifies the expression generators used by the BodyBuilder, so
that the synthetic assignments are produced directly in the output form,
since they will not be touched by type inference.
This change makes the `loop.dart`, `switch.dart`,
`instance_creation.dart`, `asserts.dart`, `field_initializers.dart`,
`optional_params.dart`, `bootstrapping.dart`, `ffi.dart`, and
`invisible.dart` tests of the bytecode generator to pass, so it can be
removed from the excluded tests when the closure-context-lowering
experiment is enabled.
Part of https://github.com/dart-lang/sdk/issues/61572
Change-Id: I8d828b7da8e33c6e9fa6bfdda1f201bcdfad9ac4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487840
Reviewed-by: Alexander Markov <alexm...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Chloe Stefantsova <cstefa...@google.com>
Files:
- M pkg/dart2bytecode/test/bytecode_generator_test.dart
- M pkg/front_end/lib/src/kernel/body_builder.dart
- M pkg/front_end/lib/src/kernel/expression_generator.dart
- M pkg/kernel/lib/src/ast/variables.dart
Change size: M
Delta: 4 files changed, 172 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther, +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages