[L] Change in dart/sdk[main]: Support more function kinds and nodes in AST-to-IR translation
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Dec 9, 2025, 1:27:08 PM12/9/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Stephen Adams, Nate Biggs, Nicholas Shahan, Tess Strickland, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Dec 10, 2025, 8:17:50 AM12/10/25
to Alexander Markov, Alexander Aprelev, Stephen Adams, Nate Biggs, Nicholas Shahan, Tess Strickland, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov
Slava Egorov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Slava Egorov
| Code-Review | +1 |
2 comments
File pkg/cfg/lib/front_end/ast_to_ir.dart
Line 113, Patchset 1 (Latest):
void _implicitGetter(ast.Field node) {Slava Egorov . unresolved
nit: consider naming these with `build` prefix (e.g. `_buildImplicitGetter`) to make it more obvious what they do.
File pkg/cfg/lib/ir/instructions.dart
Line 946, Patchset 1 (Latest):
FlowGraph graph,Slava Egorov . unresolved
Maybe `inputCount` should have been a named parameter. Then you could use `super.` parameters here as well.
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 10, 2025, 11:40:26 AM12/10/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Stephen Adams, Nate Biggs, Nicholas Shahan, Tess Strickland, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov
Alexander Markov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alexander Markov . resolved
PTAL once again - approval was removed.
File pkg/cfg/lib/front_end/ast_to_ir.dart
nit: consider naming these with `build` prefix (e.g. `_buildImplicitGetter`) to make it more obvious what they do.
Alexander Markov
Done
File pkg/cfg/lib/ir/instructions.dart
Maybe `inputCount` should have been a named parameter. Then you could use `super.` parameters here as well.
Alexander Markov
That's an excellent suggestion! Declaration of IR instructions is now more readable and has less repetitions.
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Dec 11, 2025, 3:20:56 AM12/11/25
to Alexander Markov, Alexander Aprelev, Stephen Adams, Nate Biggs, Nicholas Shahan, Tess Strickland, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 11, 2025, 9:19:17 AM12/11/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Stephen Adams, Nate Biggs, Nicholas Shahan, Tess Strickland, Commit Queue, rev...@dartlang.org
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 11, 2025, 9:19:37 AM12/11/25
to Alexander Markov, Slava Egorov, Alexander Aprelev, Stephen Adams, Nate Biggs, Nicholas Shahan, Tess Strickland, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Support more function kinds and nodes in AST-to-IR translation
Add support for getters, setters, constructors, implicit field getters,
implicit field setters, field initializers.
Support all kinds of constructor initializers, super and
constructor invocations.
Add IR instructions for field loads and stores and object allocation.
Change-Id: Ia83a3e8183958c384c2a177565abcc2b5cb0ef5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467121
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- M pkg/cfg/lib/front_end/ast_to_ir.dart
- A pkg/cfg/lib/ir/field.dart
- M pkg/cfg/lib/ir/flow_graph_builder.dart
- M pkg/cfg/lib/ir/flow_graph_checker.dart
- M pkg/cfg/lib/ir/functions.dart
- M pkg/cfg/lib/ir/instructions.dart
- M pkg/cfg/lib/ir/ir_to_text.dart
- M pkg/cfg/lib/ir/ssa_computation.dart
- M pkg/cfg/lib/ir/visitor.dart
- M pkg/cfg/lib/passes/constant_propagation.dart
- M pkg/cfg/lib/passes/simplification.dart
- M pkg/cfg/test/ir/functions_test.dart
- M pkg/cfg/test/ir_test.dart
- M pkg/cfg/testcases/calls.dart
- M pkg/cfg/testcases/calls.dart.expect
- M pkg/cfg/testcases/types.dart
- M pkg/cfg/testcases/types.dart.expect
- M pkg/cfg/testcases/unreachable_ast.dart.expect
Change size: XL
Delta: 18 files changed, 968 insertions(+), 125 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages