[XS] Change in dart/sdk[main]: [_fe_analyzer_shared] Use named super parameters in a few missed cases.
0 views
Skip to first unread message
Paul Berry (Gerrit)
11:08 AM (10 hours ago) 11:08 AM
to Samuel Rawlins, Commit Queue, rev...@dartlang.org
Attention needed from Samuel Rawlins
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
11:21 AM (9 hours ago) 11:21 AM
to Paul Berry, Commit Queue, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
11:22 AM (9 hours ago) 11:22 AM
to Samuel Rawlins, Paul Berry, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[_fe_analyzer_shared] Use named super parameters in a few missed cases.
Work towards https://github.com/dart-lang/sdk/issues/58729.
The lint rule will suggest using a super-parameter for a named
parameter even if the positional parameters cannot be super-parameters.
Change-Id: Ib61135c6ce172984251adc8afecb68a30a2d6caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491501
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages