[S] Change in dart/sdk[main]: [vm/ffi] Migrate legacy multi-test files to CFE expectations
Daco Harkes (Gerrit)
Daco Harkes added 3 comments![]( "Open in Gerrit")
Please add:
`Cq-Include-Trybots: dart/try:vm-aot-android-debug-arm64c-try,vm-aot-android-debug-arm_x64-try,vm-aot-linux-debug-arm64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-debug-arm64-try,vm-aot-mac-debug-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-asan-linux-release-arm64-try,vm-asan-linux-release-x64-try,vm-asan-mac-release-arm64-try,vm-asan-win-release-x64-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-msan-linux-release-arm64-try,vm-msan-linux-release-x64-try,vm-tsan-linux-release-arm64-try,vm-tsan-linux-release-x64-try,vm-tsan-mac-release-arm64-try,vm-ubsan-linux-release-arm64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-mac-release-arm64-try,vm-ubsan-win-release-x64-try`
which ensures we're running all the bots this test runs on.
(From `dart tools/find_builders.dart ffi/abi_specific_int_incomplete_aot_test`)
// ^^^^^^^^^^This looks shifted by the formatter. Remove two spaces again.
// [analyzer] COMPILE_TIME_ERROR.SDK_VERSION_NOT_SUPPORTEDI don't think the analyzer would know what options are passed to the VM. Are you sure you have run the tests against the right bots locally?
Related details
- Ankit Ranjan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ankit Ranjan (Gerrit)
Ankit Ranjan added 2 comments![]( "Open in Gerrit")
This looks shifted by the formatter. Remove two spaces again.
Acknowledged
// [analyzer] COMPILE_TIME_ERROR.SDK_VERSION_NOT_SUPPORTEDI don't think the analyzer would know what options are passed to the VM. Are you sure you have run the tests against the right bots locally?
Yes, the analyzer/CFE can't see VM flags there's nothing static for a [analyzer] or [cfe] expectation to catch, because the error only fires at kernel-load time in the VM
I've dropped the static-error markers in the latest patchset and rewritten the test, it spawns dart --enable-ffi=false vmspecific_enable_ffi_test_helper.dart (the helper imports dart:ffi) and asserts exit
code 254 plus the "import of dart:ffi is not supported in the current Dart runtime" message on stderr.
abi_specific_int_incomplete_aot_test follows the same pattern, running gen_kernel + gen_snapshot on a helper and checking for the "AbiSpecificInteger 'Incomplete' is missing mapping " error from gen_snapshot (native_type.cc:544).
I have tested this locally on release/arm64
dartk/vm -> tests passed
dartkp -> skipped
Related details
- Daco Harkes
- Ryan Macnak
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Ryan Macnak added 1 comment![]( "Open in Gerrit")
abi_specific_int_incomplete_aot_test: SkipByDesign # Self-spawns gen_kernel/gen_snapshot; runs once under dartk instead.Something AOT-only should run on dartkp, not dartk.
Related details
- Ankit Ranjan
- Daco Harkes
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Daco Harkes added 2 comments![]( "Open in Gerrit")
// First, compile to kernel.Maybe these two steps are easier if we simply do `dart compile aotsnapshot` with the dart executable instead. It will have the same result.
// [analyzer] COMPILE_TIME_ERROR.SDK_VERSION_NOT_SUPPORTEDAnkit RanjanI don't think the analyzer would know what options are passed to the VM. Are you sure you have run the tests against the right bots locally?
Yes, the analyzer/CFE can't see VM flags there's nothing static for a [analyzer] or [cfe] expectation to catch, because the error only fires at kernel-load time in the VM
I've dropped the static-error markers in the latest patchset and rewritten the test, it spawns dart --enable-ffi=false vmspecific_enable_ffi_test_helper.dart (the helper imports dart:ffi) and asserts exitcode 254 plus the "import of dart:ffi is not supported in the current Dart runtime" message on stderr.
abi_specific_int_incomplete_aot_test follows the same pattern, running gen_kernel + gen_snapshot on a helper and checking for the "AbiSpecificInteger 'Incomplete' is missing mapping " error from gen_snapshot (native_type.cc:544).
I have tested this locally on release/arm64
dartk/vm -> tests passed
dartkp -> skipped
SGTM
the dartkp bots build the aotruntime, so it should pass there instead of skip.
Related details
- Ankit Ranjan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |