[M] Change in dart/sdk[main]: [kernel] Remove unused Target.instantiateNoSuchMethodError

0 views
Skip to first unread message

Nate Biggs (Gerrit)

unread,
Nov 26, 2025, 11:19:00 AM (3 days ago) Nov 26
to Johnni Winther, Alexander Markov, Jens Johansen, Commit Queue, dart-dc-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov, Jens Johansen and Johnni Winther

Nate Biggs voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
  • Jens Johansen
  • Johnni Winther
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I38c4f97116f36c4cae079439367afc746415205c
Gerrit-Change-Number: 464683
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Jens Johansen <je...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Wed, 26 Nov 2025 16:18:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Jens Johansen (Gerrit)

unread,
Nov 27, 2025, 2:34:58 AM (2 days ago) Nov 27
to Johnni Winther, Nate Biggs, Alexander Markov, Commit Queue, dart-dc-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov and Johnni Winther

Jens Johansen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
  • Johnni Winther
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I38c4f97116f36c4cae079439367afc746415205c
Gerrit-Change-Number: 464683
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Thu, 27 Nov 2025 07:34:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Martin Kustermann (Gerrit)

unread,
Nov 27, 2025, 3:52:16 AM (2 days ago) Nov 27
to Johnni Winther, Alexander Markov, Jens Johansen, Nate Biggs, Commit Queue, dart-dc-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov and Johnni Winther

Martin Kustermann voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I38c4f97116f36c4cae079439367afc746415205c
Gerrit-Change-Number: 464683
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Thu, 27 Nov 2025 08:52:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Nov 27, 2025, 4:23:55 AM (2 days ago) Nov 27
to Martin Kustermann, Alexander Markov, Jens Johansen, Nate Biggs, Commit Queue, dart-dc-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov

Johnni Winther voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I38c4f97116f36c4cae079439367afc746415205c
    Gerrit-Change-Number: 464683
    Gerrit-PatchSet: 3
    Gerrit-Owner: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Jens Johansen <je...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
    Gerrit-Reviewer: Nate Biggs <nate...@google.com>
    Gerrit-CC: Alexander Markov <alexm...@google.com>
    Gerrit-Attention: Alexander Markov <alexm...@google.com>
    Gerrit-Comment-Date: Thu, 27 Nov 2025 09:23:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Johnni Winther (Gerrit)

    unread,
    Nov 27, 2025, 4:50:50 AM (2 days ago) Nov 27
    to Martin Kustermann, Alexander Markov, Jens Johansen, Nate Biggs, Commit Queue, dart-dc-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
    Gerrit-Comment-Date: Thu, 27 Nov 2025 09:50:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Johnni Winther (Gerrit)

    unread,
    Nov 27, 2025, 4:55:55 AM (2 days ago) Nov 27
    to Martin Kustermann, Alexander Markov, Jens Johansen, Nate Biggs, Commit Queue, dart-dc-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
    Gerrit-Comment-Date: Thu, 27 Nov 2025 09:55:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Nov 27, 2025, 4:56:12 AM (2 days ago) Nov 27
    to Johnni Winther, Martin Kustermann, Alexander Markov, Jens Johansen, Nate Biggs, dart-dc-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Unreviewed changes

    2 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [kernel] Remove unused Target.instantiateNoSuchMethodError

    TEST=existing
    Change-Id: I38c4f97116f36c4cae079439367afc746415205c
    Reviewed-by: Jens Johansen <je...@google.com>
    Commit-Queue: Johnni Winther <johnni...@google.com>
    Reviewed-by: Nate Biggs <nate...@google.com>
    Reviewed-by: Martin Kustermann <kuste...@google.com>
    Files:
    • M pkg/compiler/lib/src/kernel/dart2js_target.dart
    • M pkg/dart2wasm/lib/target.dart
    • M pkg/dev_compiler/lib/src/kernel/target.dart
    • M pkg/kernel/lib/target/targets.dart
    • M pkg/vm/lib/modular/target/vm.dart
    Change size: M
    Delta: 5 files changed, 0 insertions(+), 165 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jens Johansen, +1 by Martin Kustermann, +1 by Nate Biggs
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I38c4f97116f36c4cae079439367afc746415205c
    Gerrit-Change-Number: 464683
    Gerrit-PatchSet: 4
    Gerrit-Owner: Johnni Winther <johnni...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages