[M] Change in dart/sdk[main]: [js_runtime] Modernize and simplify `_AsyncRun._scheduleImmediate`.
0 views
Skip to first unread message
Mayank Patke (Gerrit)
Aug 8, 2025, 6:45:01 PM8/8/25
to Stephen Adams, Commit Queue, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Stephen Adams
Mayank Patke voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Stephen Adams
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Adams (Gerrit)
Aug 8, 2025, 7:06:14 PM8/8/25
to Mayank Patke, Commit Queue, dart2js-te...@google.com, rev...@dartlang.org
Stephen Adams voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 8, 2025, 7:06:23 PM8/8/25
to Stephen Adams, Mayank Patke, dart2js-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[js_runtime] Modernize and simplify `_AsyncRun._scheduleImmediate`.
Use browser's `queueMicrotask` if available.
Remove `MutationObserver` method, since `queueMicrotask` is available on all supported browsers.
Simplify by removing `internalCallback`. This is no longer needed (it used to do more than just call the callback).
Issue: #20055
Change-Id: Ic866cdd77787fc45456f65a6618fe66afcbcb970
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444392
Reviewed-by: Mayank Patke <fishyt...@google.com>
Commit-Queue: Stephen Adams <s...@google.com>
Files:
- M sdk/lib/_internal/js_runtime/lib/async_patch.dart
Change size: M
Delta: 1 file changed, 15 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mayank Patke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages