[M] Change in dart/sdk[main]: [analysis_server] Update LSP Selection Range tests to use EOL normali...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Oct 14, 2025, 4:02:32 PM (7 days ago) Oct 14
to Danny Tuppeny, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny and Samuel Rawlins
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
| Commit-Queue | +1 |
1 comment
File pkg/analysis_server/test/utils/matchers.dart
Line 15, Patchset 1 (Latest):
_ => throw UnimplementedError('Matcher $expected it not supported'),Brian Wilkerson . unresolved
Did this want to be `${expected.runtimeType}`, or did you really want the whole `printString` of the expected object? Given that it's just an exception message it probably doesn't matter much, but ...
Also the message overall doesn't read quite right to me. Maybe "it" should be "is"? Or maybe the whole thing should be something like "Can't normalize a ${expected.runtimeType}"?
Related details
Attention is currently required from:
- Danny Tuppeny
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danny Tuppeny (Gerrit)
Oct 14, 2025, 4:22:58 PM (7 days ago) Oct 14
to Commit Queue, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Danny Tuppeny added 1 comment![]( "Open in Gerrit")
File pkg/analysis_server/test/utils/matchers.dart
Line 15, Patchset 1:
_ => throw UnimplementedError('Matcher $expected it not supported'),Brian Wilkerson . resolved
Did this want to be `${expected.runtimeType}`, or did you really want the whole `printString` of the expected object? Given that it's just an exception message it probably doesn't matter much, but ...
Also the message overall doesn't read quite right to me. Maybe "it" should be "is"? Or maybe the whole thing should be something like "Can't normalize a ${expected.runtimeType}"?
Danny Tuppeny
Yeah, I think that's much better. I've edited it in (though it probably interrupted the bots). Thanks!
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Oct 14, 2025, 4:29:11 PM (7 days ago) Oct 14
to Danny Tuppeny, Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny and Samuel Rawlins
Brian Wilkerson voted![]( "Open in Gerrit")
Attention is currently required from:
- Danny Tuppeny
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danny Tuppeny (Gerrit)
Oct 20, 2025, 10:47:01 AM (yesterday) Oct 20
to Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Danny Tuppeny added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Oct 20, 2025, 10:55:55 AM (yesterday) Oct 20
to Danny Tuppeny, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Danny Tuppeny
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Oct 20, 2025, 10:56:41 AM (yesterday) Oct 20
to Danny Tuppeny, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Danny Tuppeny
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 20, 2025, 11:23:24 AM (yesterday) Oct 20
to Danny Tuppeny, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[analysis_server] Update LSP Selection Range tests to use EOL normalization
This is work towards making all tests normalize EOLs to the current platform by default.
See https://github.com/dart-lang/sdk/issues/60234
Change-Id: Ie378089517698cc100d959108ed6445b901de048
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454940
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analysis_server/test/lsp/selection_range_test.dart
- M pkg/analysis_server/test/utils/matchers.dart
Change size: M
Delta: 2 files changed, 44 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages