[S] Change in dart/sdk[stable]: [stable] [CFE/kernel] Clear invalidated ClassHierarchySubtypes
0 views
Skip to first unread message
Johnni Winther (Gerrit)
Nov 27, 2025, 8:16:31 AM (3 days ago) Nov 27
to Jens Johansen, Commit Queue, Alexander Markov, rev...@dartlang.org
Attention needed from Jens Johansen
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jens Johansen
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jens Johansen (Gerrit)
Nov 27, 2025, 8:22:44 AM (3 days ago) Nov 27
to Johnni Winther, Commit Queue, Alexander Markov, rev...@dartlang.org
Jens Johansen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jens Johansen . resolved
From http://g2/group/dart-admin.prod I see that Slava is a cherry pick reviewer
Related details
Attention set is empty
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jens Johansen (Gerrit)
Nov 28, 2025, 2:34:48 AM (yesterday) Nov 28
to Slava Egorov, Johnni Winther, Commit Queue, Alexander Markov, rev...@dartlang.org
Attention needed from Slava Egorov
Jens Johansen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jens Johansen . resolved
From http://g2/group/dart-admin.prod I see that Slava is a cherry pick reviewer
Jens Johansen
But I need to remember to actually add him 😊
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Nov 28, 2025, 6:45:47 AM (yesterday) Nov 28
to Jens Johansen, Johnni Winther, Commit Queue, Alexander Markov, rev...@dartlang.org
Attention needed from Jens Johansen
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jens Johansen
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jens Johansen (Gerrit)
Nov 28, 2025, 7:38:38 AM (yesterday) Nov 28
to Slava Egorov, Johnni Winther, Commit Queue, Alexander Markov, rev...@dartlang.org
Jens Johansen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Nov 28, 2025, 8:16:19 AM (yesterday) Nov 28
to Jens Johansen, Slava Egorov, Johnni Winther, Alexander Markov, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[stable] [CFE/kernel] Clear invalidated ClassHierarchySubtypes
When recompiling (`computeDelta`) the class hierarchy is made up
to date and the old ClassHierarchySubtypes (if any) is marked as
invalid, but was erroneously not cleared, meaning that when trying
to use it (via expression compilation) it would through.
This fixes it be clearing it, meaning that it will be recreated in a
correct state if/when needed.
Fixes https://github.com/flutter/flutter/issues/178740
Risk: Low
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/464380
Change-Id: Ib2dbca09c4d483fa9d798c1d147c164737e73aff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464860
Commit-Queue: Jens Johansen <je...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Files:
- M CHANGELOG.md
- M pkg/kernel/lib/class_hierarchy.dart
- M pkg/kernel/test/class_hierarchy_test.dart
Change size: S
Delta: 3 files changed, 37 insertions(+), 1 deletion(-)
Branch: refs/heads/stable
Submit Requirements:
Cherry-Pick-Review: Code-Review+1 by Slava Egorov, Code-Review+1 by Johnni Winther
Code-Review: +1 by Slava Egorov, +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages