[M] Change in dart/sdk[main]: [analysis_server_plugin] Fixes non-`LintCode` fixes showing up for users

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Feb 11, 2026, 9:59:58 PM (5 days ago) Feb 11
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[analysis_server_plugin] Fixes non-`LintCode` fixes showing up for users
Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be

Change information

Files:
  • M pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart
  • M pkg/analysis_server/lib/src/services/correction/dart/add_missing_required_argument.dart
  • M pkg/analysis_server/lib/src/services/correction/dart/import_library.dart
  • M pkg/analysis_server/lib/src/services/correction/dart/remove_const.dart
  • M pkg/analysis_server/lib/src/services/correction/fix_internal.dart
  • M pkg/analysis_server/test/src/services/correction/fix/data_driven/data_driven_test.dart
  • M pkg/analysis_server/test/src/services/correction/fix/fix_processor_map_test.dart
  • M pkg/analysis_server/tool/bulk_fix/supported_diagnostics.dart
  • M pkg/analysis_server/tool/presubmit/verify_error_fix_status.dart
  • M pkg/analysis_server_plugin/lib/src/correction/fix_generators.dart
  • M pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart
  • M pkg/analysis_server_plugin/lib/src/correction/fix_processor.dart
  • M pkg/analysis_server_plugin/lib/src/registry.dart
  • M pkg/analysis_server_plugin/test/src/lint_rules.dart
  • M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
  • M pkg/analysis_server_plugin/test/src/plugin_server_test_base.dart
Change size: M
Delta: 16 files changed, 120 insertions(+), 26 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be
Gerrit-Change-Number: 480080
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Feb 11, 2026, 10:08:38 PM (5 days ago) Feb 11
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel added 1 comment

File pkg/analysis_server_plugin/lib/src/correction/fix_generators.dart
Line 52, Patchset 1 (Latest): final Map<DiagnosticCode, List<ProducerGenerator>> warningProducers = {};
Felipe Morschel . unresolved

I wasn't sure about this rename. But I figured since this is how we refer to them on the plugin code, we could do the same here internally.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be
Gerrit-Change-Number: 480080
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 03:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Feb 11, 2026, 10:11:08 PM (5 days ago) Feb 11
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel added 1 comment

File pkg/analysis_server_plugin/test/src/lint_rules.dart
Line 61, Patchset 1 (Latest):class TestDiagnosticCode extends DiagnosticCode {
Felipe Morschel . resolved

This is against the docs on `DiagnosticCode`, but I've asked for more instructions over at https://github.com/dart-lang/sdk/issues/61949#issuecomment-3888413452, and since this is merely a test, I think we are fine doing it.

Noting that this was basically copy/pasted from inside `linter`, so there is a need for this.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be
Gerrit-Change-Number: 480080
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 03:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Feb 12, 2026, 9:27:49 PM (4 days ago) Feb 12
to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted and added 2 comments

Votes added by Samuel Rawlins

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved

Looks great, thanks for the fix!

File pkg/analysis_server_plugin/lib/src/correction/fix_generators.dart
Line 52, Patchset 1 (Latest): final Map<DiagnosticCode, List<ProducerGenerator>> warningProducers = {};
Felipe Morschel . resolved

I wasn't sure about this rename. But I figured since this is how we refer to them on the plugin code, we could do the same here internally.

Samuel Rawlins

I think this is probably a good name. 👍

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Felipe Morschel
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be
Gerrit-Change-Number: 480080
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Comment-Date: Fri, 13 Feb 2026 02:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felipe Morschel <g...@fmorschel.dev>
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Feb 13, 2026, 4:58:07 PM (3 days ago) Feb 13
to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Brian Wilkerson voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be
    Gerrit-Change-Number: 480080
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Fri, 13 Feb 2026 21:58:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Feb 13, 2026, 4:58:24 PM (3 days ago) Feb 13
    to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [analysis_server_plugin] Fixes non-`LintCode` fixes showing up for users
    Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be
    Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
    Commit-Queue: Brian Wilkerson <brianwi...@google.com>
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart
    • M pkg/analysis_server/lib/src/services/correction/dart/add_missing_required_argument.dart
    • M pkg/analysis_server/lib/src/services/correction/dart/import_library.dart
    • M pkg/analysis_server/lib/src/services/correction/dart/remove_const.dart
    • M pkg/analysis_server/lib/src/services/correction/fix_internal.dart
    • M pkg/analysis_server/test/src/services/correction/fix/data_driven/data_driven_test.dart
    • M pkg/analysis_server/test/src/services/correction/fix/fix_processor_map_test.dart
    • M pkg/analysis_server/tool/bulk_fix/supported_diagnostics.dart
    • M pkg/analysis_server/tool/presubmit/verify_error_fix_status.dart
    • M pkg/analysis_server_plugin/lib/src/correction/fix_generators.dart
    • M pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart
    • M pkg/analysis_server_plugin/lib/src/correction/fix_processor.dart
    • M pkg/analysis_server_plugin/lib/src/registry.dart
    • M pkg/analysis_server_plugin/test/src/lint_rules.dart
    • M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
    • M pkg/analysis_server_plugin/test/src/plugin_server_test_base.dart
    Change size: M
    Delta: 16 files changed, 120 insertions(+), 26 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Samuel Rawlins, +1 by Brian Wilkerson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I180934a9ead47ae25cf5ef9ea633f43a994ca3be
    Gerrit-Change-Number: 480080
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages