[XS] Change in dart/sdk[main]: [dart2wasm] Remove unused bash function find_flags

0 views
Skip to first unread message

Ömer Ağacan (Gerrit)

unread,
Dec 19, 2025, 9:52:31 AM (2 days ago) Dec 19
to Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Nate Biggs

Ömer Ağacan voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nate Biggs
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3faf8784f4fbc2c940ec4811966a8c9d54f873f
Gerrit-Change-Number: 469160
Gerrit-PatchSet: 1
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 14:52:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Biggs (Gerrit)

unread,
Dec 19, 2025, 11:36:59 AM (2 days ago) Dec 19
to Ömer Ağacan, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Ömer Ağacan

Nate Biggs voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ömer Ağacan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3faf8784f4fbc2c940ec4811966a8c9d54f873f
Gerrit-Change-Number: 469160
Gerrit-PatchSet: 1
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 16:36:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Nate Biggs (Gerrit)

unread,
Dec 19, 2025, 11:37:11 AM (2 days ago) Dec 19
to Ömer Ağacan, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Ömer Ağacan

Nate Biggs added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nate Biggs . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Ömer Ağacan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3faf8784f4fbc2c940ec4811966a8c9d54f873f
Gerrit-Change-Number: 469160
Gerrit-PatchSet: 1
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 16:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 19, 2025, 12:10:29 PM (2 days ago) Dec 19
to Ömer Ağacan, Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[dart2wasm] Remove unused bash function find_flags
Change-Id: Id3faf8784f4fbc2c940ec4811966a8c9d54f873f
Auto-Submit: Ömer Ağacan <ome...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Nate Biggs <nate...@google.com>
Files:
  • M pkg/dart2wasm/tool/compile_benchmark
Change size: XS
Delta: 1 file changed, 0 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Biggs
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3faf8784f4fbc2c940ec4811966a8c9d54f873f
Gerrit-Change-Number: 469160
Gerrit-PatchSet: 2
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages