[XS] Change in dart/sdk[main]: [infra] Roll clang to d0ddae678e3f634c988542dfbdde1dd0afe66344.
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Mar 13, 2026, 1:55:42 PMMar 13
to Alexander Aprelev, Alexander Markov, Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Code-Review | +1 |
1 comment
File runtime/bin/dart_io_api_impl.cc
Line 148, Patchset 1 (Latest):
DartUtils::GetDartType(DartUtils::kIOLibURL, "_NetworkProfiling");Alexander Markov . unresolved
Why is this change needed? How is this code different from code at L122-124?
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Mar 13, 2026, 1:57:32 PMMar 13
to Alexander Aprelev, Alexander Markov, Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Alexander Aprelev added 1 comment![]( "Open in Gerrit")
File runtime/bin/dart_io_api_impl.cc
Line 148, Patchset 1 (Latest):
DartUtils::GetDartType(DartUtils::kIOLibURL, "_NetworkProfiling");Alexander Markov . resolved
Why is this change needed? How is this code different from code at L122-124?
Alexander Aprelev
New clang format is getting confused by the original statement: new clang format tries to put it on one line, but then clang check fails because the line gets too long.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Mar 13, 2026, 3:34:26 PMMar 13
to Alexander Aprelev, Alexander Markov, Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Alexander Aprelev voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 13, 2026, 3:34:44 PMMar 13
to Alexander Aprelev, Alexander Markov, Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[infra] Roll clang to d0ddae678e3f634c988542dfbdde1dd0afe66344.
Update clang format, remove boringssl err.h from clang-tidy
TEST=ci
Change-Id: Ib73d89b292ee4dfa2249ec519071e7621bb92c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487885
Reviewed-by: Alexander Markov <alexm...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Files:
- M DEPS
- M runtime/.clang-tidy
- M runtime/bin/dart_io_api_impl.cc
Change size: XS
Delta: 3 files changed, 5 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages