[M] Change in dart/sdk[main]: [DAS] Fixes values suggestion without enum name
0 views
Skip to first unread message
Felipe Morschel (Gerrit)
Aug 8, 2025, 10:08:00 AM8/8/25
to dart-analys...@google.com, rev...@dartlang.org
Felipe Morschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[DAS] Fixes values suggestion without enum name
Change-Id: I6938d0ce60aaf50e71e4f1df644217f0344a89d6
Change information
Files:
- M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
- M pkg/analysis_server/test/lsp/completion_dart_test.dart
- M pkg/analysis_server/test/services/completion/dart/location/dot_shorthand_property_access_test.dart
- M pkg/analysis_server/test/services/completion/dart/location/enum_declaration_test.dart
Change size: M
Delta: 4 files changed, 68 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Aug 8, 2025, 10:10:53 AM8/8/25
to Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Danny Tuppeny and Samuel Rawlins
Felipe Morschel added 1 comment![]( "Open in Gerrit")
File pkg/analysis_server/test/lsp/completion_dart_test.dart
Line 108, Patchset 1 (Latest):
Future<void> assertNoCompletionItem(String label) async {Felipe Morschel . unresolved
WDYT about this method @da...@tuppeny.com? I couldn't find anything similar but maybe I missed something.
Related details
Attention is currently required from:
- Brian Wilkerson
- Danny Tuppeny
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Aug 24, 2025, 11:46:34 PM8/24/25
to Felipe Morschel, Brian Wilkerson, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Danny Tuppeny and Felipe Morschel
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
File pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
Line 2761, Patchset 2 (Latest):
if (name == 'values' &&Samuel Rawlins . unresolved
This could just be `return name == ...`.
Related details
Attention is currently required from:
- Brian Wilkerson
- Danny Tuppeny
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Aug 26, 2025, 12:18:59 AM8/26/25
to Commit Queue, Samuel Rawlins, Brian Wilkerson, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Danny Tuppeny and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
File pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
This could just be `return name == ...`.
Attention is currently required from:
- Brian Wilkerson
- Danny Tuppeny
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danny Tuppeny (Gerrit)
Aug 26, 2025, 4:38:25 AM8/26/25
to Felipe Morschel, Commit Queue, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Felipe Morschel and Samuel Rawlins
Danny Tuppeny added 1 comment![]( "Open in Gerrit")
File pkg/analysis_server/test/lsp/completion_dart_test.dart
Line 108, Patchset 1:
Future<void> assertNoCompletionItem(String label) async {Felipe Morschel . resolved
WDYT about this method @da...@tuppeny.com? I couldn't find anything similar but maybe I missed something.
Danny Tuppeny
Looks fair to me, although I think the failure message might be slightly better if you did something like:
```
expect(completions.where((c) => c.label == label), isEmpty);
```
Because I think your current code would fail with "Expected true, got false" whereas using `isEmpty` I think would give something like "Expected empty, but got <toString version of the results>". If the completion items have useful toStrings() (not a guarantee), this might be a slightly more useful message.
Related details
Attention is currently required from:
- Brian Wilkerson
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Aug 28, 2025, 1:17:10 PM8/28/25
to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins
Brian Wilkerson voted![]( "Open in Gerrit")
Attention is currently required from:
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Aug 28, 2025, 1:40:11 PM8/28/25
to Brian Wilkerson, Commit Queue, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Felipe Morschel . unresolved
Friendly ping @sraw...@google.com. Could you please give me a new review here? Thanks a lot!
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Aug 28, 2025, 8:30:15 PM8/28/25
to Felipe Morschel, Brian Wilkerson, Commit Queue, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Felipe Morschel . resolved
Friendly ping @sraw...@google.com. Could you please give me a new review here? Thanks a lot!
Attention is currently required from:
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 28, 2025, 8:30:36 PM8/28/25
to Felipe Morschel, Samuel Rawlins, Brian Wilkerson, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[DAS] Fixes values suggestion without enum name
Change-Id: I6938d0ce60aaf50e71e4f1df644217f0344a89d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444441
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Files:
- M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
- M pkg/analysis_server/test/lsp/completion_dart_test.dart
- M pkg/analysis_server/test/services/completion/dart/declaration/enum_test.dart
- M pkg/analysis_server/test/services/completion/dart/location/dot_shorthand_property_access_test.dart
- M pkg/analysis_server/test/services/completion/dart/location/enum_declaration_test.dart
Change size: M
Delta: 5 files changed, 111 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins, +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages