Jens Johansen (Gerrit)

unread,

3:59 AM (7 hours ago) 3:59 AM

to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org

Attention needed from Johnni Winther

Jens Johansen added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jens Johansen . resolved

ping. (I approved the failure on co19/VM/primary_constructors_t01 --- it now stops at a different point (at `)` instead of at `(` which I suppose makes sense).

Open in Gerrit

Related details

Attention is currently required from:

Johnni Winther

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Johnni Winther (Gerrit)

unread,

4:03 AM (7 hours ago) 4:03 AM

to Jens Johansen, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org

Attention needed from Jens Johansen

Johnni Winther voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jens Johansen

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Jens Johansen (Gerrit)

unread,

4:18 AM (7 hours ago) 4:18 AM

to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org

Jens Johansen voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

4:19 AM (7 hours ago) 4:19 AM

to Jens Johansen, Johnni Winther, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[CFE] Set proper endOffset on constructor from primary constructor

If nothing else it's needed for
https://github.com/dart-lang/sdk/issues/62645.

Change-Id: Ibcc4cdd292cdec0c33a24c337861e1dd54da24f7

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/496981

Reviewed-by: Johnni Winther <johnni...@google.com>

Commit-Queue: Jens Johansen <je...@google.com>

Files:

M pkg/_fe_analyzer_shared/lib/src/parser/forwarding_listener.dart
M pkg/_fe_analyzer_shared/lib/src/parser/listener.dart
M pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
M pkg/analyzer/lib/src/fasta/ast_builder.dart
M pkg/front_end/lib/src/fragment/constructor/declaration.dart
M pkg/front_end/lib/src/fragment/primary_constructor.dart
M pkg/front_end/lib/src/source/diet_listener.dart
M pkg/front_end/lib/src/source/fragment_factory.dart
M pkg/front_end/lib/src/source/fragment_factory_impl.dart
M pkg/front_end/lib/src/source/outline_builder.dart
M pkg/front_end/lib/src/util/parser_ast_helper.dart
M pkg/front_end/parser_testcases/inline_class/extends_with.dart.expect
M pkg/front_end/parser_testcases/inline_class/extends_with.dart.intertwined.expect
M pkg/front_end/parser_testcases/inline_class/extension_type.dart.expect
M pkg/front_end/parser_testcases/inline_class/extension_type.dart.intertwined.expect
M pkg/front_end/parser_testcases/inline_class/extension_type_const.dart.expect
M pkg/front_end/parser_testcases/inline_class/extension_type_const.dart.intertwined.expect
M pkg/front_end/parser_testcases/inline_class/extension_type_missing_name.dart.expect
M pkg/front_end/parser_testcases/inline_class/extension_type_missing_name.dart.intertwined.expect
M pkg/front_end/parser_testcases/inline_class/extension_type_on.dart.expect
M pkg/front_end/parser_testcases/inline_class/extension_type_on.dart.intertwined.expect
M pkg/front_end/parser_testcases/inline_class/no_body.dart.expect
M pkg/front_end/parser_testcases/inline_class/no_body.dart.intertwined.expect
M pkg/front_end/parser_testcases/inline_class/no_primary_constructor.dart.expect
M pkg/front_end/parser_testcases/inline_class/no_primary_constructor.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_body.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_body.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_body_error.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_body_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_error.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/declaring_parameter.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/declaring_parameter.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/declaring_parameter_error.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/declaring_parameter_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/declaring_parameter_pre_feature.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/declaring_parameter_pre_feature.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_body.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_body.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_body_error.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_body_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_error.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor_body.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor_body.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor_body_error.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor_body_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor_error.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/extension_type_primary_constructor_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/new_dot_name.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/new_dot_name.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/no_class_body.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/no_class_body.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/no_class_extension_type_body_pre_feature.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/no_class_extension_type_body_pre_feature.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/no_extension_type_body.dart.expect
M pkg/front_end/parser_testcases/primary_constructors/no_extension_type_body.dart.intertwined.expect
M pkg/front_end/test/parser_test_listener.dart
M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.expect
M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.modular.expect
M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.outline.expect
M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.transformed.expect
M pkg/front_end/testcases/offsets/external_field.dart.strong.expect
M pkg/front_end/testcases/offsets/external_field.dart.strong.modular.expect
M pkg/front_end/testcases/offsets/external_field.dart.strong.outline.expect
M pkg/front_end/testcases/offsets/external_field.dart.strong.transformed.expect

Change size: XL

Delta: 72 files changed, 876 insertions(+), 854 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Johnni Winther

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[XL] Change in dart/sdk[main]: [CFE] Set proper endOffset on constructor from primary constructor

Jens Johansen (Gerrit)

Jens Johansen added 1 comment

Related details

Johnni Winther (Gerrit)

Johnni Winther voted Code-Review+1

Related details

Jens Johansen (Gerrit)

Jens Johansen voted Commit-Queue+2

Related details

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information