[XS] Change in dart/sdk[main]: [pkg/dartdev] Allow cross compilation to Linux ARM/RISCV64.

0 views
Skip to first unread message

Tess Strickland (Gerrit)

unread,
Jun 30, 2025, 9:13:14 AM6/30/25
to Ivan Inozemtsev, rev...@dartlang.org
Attention needed from Ivan Inozemtsev

Tess Strickland added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tess Strickland . resolved

When should this CL be landed? After the recipes CL, but how long after?

Open in Gerrit

Related details

Attention is currently required from:
  • Ivan Inozemtsev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia91c9fa44101f7b4202ab717fe1cba6a3470bf31
Gerrit-Change-Number: 437760
Gerrit-PatchSet: 1
Gerrit-Owner: Tess Strickland <sstr...@google.com>
Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Attention: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Comment-Date: Mon, 30 Jun 2025 13:13:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ivan Inozemtsev (Gerrit)

unread,
Jul 1, 2025, 4:25:19 AM7/1/25
to Tess Strickland, Commit Queue, rev...@dartlang.org
Attention needed from Tess Strickland

Ivan Inozemtsev voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tess Strickland
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia91c9fa44101f7b4202ab717fe1cba6a3470bf31
Gerrit-Change-Number: 437760
Gerrit-PatchSet: 1
Gerrit-Owner: Tess Strickland <sstr...@google.com>
Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Reviewer: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Tess Strickland <sstr...@google.com>
Gerrit-Comment-Date: Tue, 01 Jul 2025 08:25:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tess Strickland (Gerrit)

unread,
Jul 2, 2025, 9:22:06 AM7/2/25
to Ivan Inozemtsev, Commit Queue, rev...@dartlang.org

Tess Strickland voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia91c9fa44101f7b4202ab717fe1cba6a3470bf31
Gerrit-Change-Number: 437760
Gerrit-PatchSet: 5
Gerrit-Owner: Tess Strickland <sstr...@google.com>
Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Reviewer: Tess Strickland <sstr...@google.com>
Gerrit-Comment-Date: Wed, 02 Jul 2025 13:22:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Jul 2, 2025, 10:57:31 AM7/2/25
to Tess Strickland, Ivan Inozemtsev, rev...@dartlang.org

Commit Queue submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: pkg/dartdev/lib/src/commands/compile.dart
Insertions: 2, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
[pkg/dartdev] Allow cross compilation to Linux ARM/RISCV64.

Note that Linux ARM cross compilation is not currently supported
on Windows.

Follow-up CL to:

* https://dart-review.googlesource.com/c/sdk/+/437720
* https://dart-review.googlesource.com/c/recipes/+/437740

TEST=ci
Change-Id: Ia91c9fa44101f7b4202ab717fe1cba6a3470bf31
Reviewed-by: Ivan Inozemtsev <iinoz...@google.com>
Commit-Queue: Tess Strickland <sstr...@google.com>
Files:
  • M pkg/dartdev/lib/src/commands/compile.dart
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ivan Inozemtsev
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia91c9fa44101f7b4202ab717fe1cba6a3470bf31
Gerrit-Change-Number: 437760
Gerrit-PatchSet: 6
Gerrit-Owner: Tess Strickland <sstr...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages