[L] Change in dart/sdk[main]: meta: Annotate visibleForOverriding and visibleForTesting with Target...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Dec 17, 2025, 1:44:03 PM (4 days ago) Dec 17
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Dec 18, 2025, 1:11:32 PM (3 days ago) Dec 18
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 18, 2025, 2:22:44 PM (3 days ago) Dec 18
to Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 18, 2025, 3:05:48 PM (3 days ago) Dec 18
to Samuel Rawlins, Paul Berry, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
meta: Annotate visibleForOverriding and visibleForTesting with TargetKinds
In the analyzer, remove our custom warning for `visibleForOverriding`,
`invalid_visible_for_overriding_annotation` (replaced by the existing
`invalid_annotation_target` warning). The tests for that warning are
mostly covered by the existing `invalid_annotation_target` tests, but
I added a few to fill some gaps.
Work towards https://github.com/dart-lang/sdk/issues/62253
Change-Id: Ie960db6ebe007afde787f68e4b6b9f20a1835639
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/468702
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
- M pkg/analysis_server/lib/src/services/correction/fix_internal.dart
- M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
- M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
- M pkg/analyzer/lib/src/error/annotation_verifier.dart
- M pkg/analyzer/messages.yaml
- M pkg/analyzer/test/src/diagnostics/invalid_annotation_target_test.dart
- D pkg/analyzer/test/src/diagnostics/invalid_visible_for_overriding_annotation_test.dart
- M pkg/analyzer/test/src/diagnostics/test_all.dart
- M pkg/analyzer_testing/lib/src/mock_packages/meta/meta.dart
- M pkg/meta/lib/meta.dart
Change size: L
Delta: 11 files changed, 124 insertions(+), 239 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry, +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages