[M] Change in dart/sdk[main]: [vm] Don't double initialize length fields during object graph copying.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Jul 15, 2026, 3:23:26 PM (13 hours ago) Jul 15
to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Jul 15, 2026, 3:44:57 PM (12 hours ago) Jul 15
to Ryan Macnak, Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Jul 15, 2026, 3:52:05 PM (12 hours ago) Jul 15
to Ryan Macnak, Alexander Markov, Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Markov added 1 comment![]( "Open in Gerrit")
File runtime/vm/object_graph_copy.cc
Line 1835, Patchset 3 (Latest):
Base::StoreCompressedPointersNoBarrier(from, to,
OFFSET_OF(UntaggedArray, length_),
OFFSET_OF(UntaggedArray, length_));Alexander Markov . unresolved
DBC
Why is this not moved under the `else` part above?
Related details
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jul 15, 2026, 3:52:10 PM (12 hours ago) Jul 15
to Alexander Markov, Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 15, 2026, 3:52:24 PM (12 hours ago) Jul 15
to Ryan Macnak, Alexander Markov, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Don't double initialize length fields during object graph copying.
Avoids supurious data race with the concurrent marker.
TEST=tsan
Bug: https://github.com/dart-lang/sdk/issues/63817
Bug: https://github.com/dart-lang/sdk/issues/63181
Change-Id: I4c0873cb5fbf9088592268fda9a1d5979eb449eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/524232
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Files:
- M runtime/vm/object_graph_copy.cc
- M runtime/vm/raw_object.cc
- M runtime/vm/raw_object.h
Change size: M
Delta: 3 files changed, 35 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jul 15, 2026, 5:40:57 PM (10 hours ago) Jul 15
to dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak added 2 comments![]( "Open in Gerrit")
File runtime/vm/object_graph_copy.cc
Line 1835, Patchset 3:
Base::StoreCompressedPointersNoBarrier(from, to,
OFFSET_OF(UntaggedArray, length_),
OFFSET_OF(UntaggedArray, length_));Alexander Markov . resolved
DBC
Why is this not moved under the `else` part above?
Line 1835, Patchset 3:
Base::StoreCompressedPointersNoBarrier(from, to,
OFFSET_OF(UntaggedArray, length_),
OFFSET_OF(UntaggedArray, length_));Alexander Markov . unresolved
DBC
Why is this not moved under the `else` part above?
Ryan Macnak
Good catch!
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages