[L] Change in dart/sdk[main]: CQ. AST. Mark visitors and related as ToBeDeprecated.

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
Jul 15, 2026, 10:58:09 AM (14 hours ago) Jul 15
to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic30da9cba72da33a9d7c6429198aa1cb506abbf0
Gerrit-Change-Number: 524266
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Wed, 15 Jul 2026 14:58:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Jul 15, 2026, 12:45:42 PM (12 hours ago) Jul 15
to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry

Konstantin Shcheglov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Berry
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic30da9cba72da33a9d7c6429198aa1cb506abbf0
Gerrit-Change-Number: 524266
Gerrit-PatchSet: 2
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Comment-Date: Wed, 15 Jul 2026 16:45:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jul 15, 2026, 12:45:52 PM (12 hours ago) Jul 15
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
CQ. AST. Mark visitors and related as ToBeDeprecated.
Change-Id: Ic30da9cba72da33a9d7c6429198aa1cb506abbf0
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Files:
  • M pkg/analyzer/lib/analysis_rule/rule_visitor_registry.dart
  • M pkg/analyzer/lib/analysis_rule/rule_visitor_registry.g.dart
  • M pkg/analyzer/lib/dart/ast/visitor.dart
  • M pkg/analyzer/lib/dart/ast/visitor.g.dart
  • M pkg/analyzer/lib/src/analysis_rule/analysis_rule.dart
  • M pkg/analyzer/lib/src/dart/ast/ast.dart
  • M pkg/analyzer/lib/src/dart/ast/ast.g.dart
  • M pkg/analyzer/lib/src/dart/ast/to_source_visitor.dart
  • M pkg/analyzer/lib/src/generated/inference_log.dart
  • M pkg/analyzer/lib/src/lint/linter_visitor.dart
  • M pkg/analyzer/lib/src/lint/linter_visitor.g.dart
  • M pkg/analyzer/test/src/dart/analysis/driver_test.dart
  • M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
  • M pkg/analyzer/test/src/diagnostics/unignorable_ignore_test.dart
  • M pkg/analyzer/test/src/summary/resolved_ast_printer.dart
  • M pkg/analyzer/tool/ast/generate.dart
  • M pkg/analyzer/tool/generators/ast_generator.dart
Change size: L
Delta: 17 files changed, 461 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Johnni Winther
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic30da9cba72da33a9d7c6429198aa1cb506abbf0
Gerrit-Change-Number: 524266
Gerrit-PatchSet: 3
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages