[L] Change in dart/sdk[stable]: [stable] Fix Process::Exec stdio handle inheritance
0 views
Skip to first unread message
Slava Egorov (Gerrit)
3:27 AM (12 hours ago) 3:27 AM
to Martin Kustermann, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Martin Kustermann
Slava Egorov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Slava Egorov . resolved
PTAL, would like to land this before cutoff.
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Thomas (Gerrit)
4:44 AM (11 hours ago) 4:44 AM
to Slava Egorov, Martin Kustermann, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Martin Kustermann and Slava Egorov
Alexander Thomas voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Martin Kustermann
- Slava Egorov
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
4:56 AM (11 hours ago) 4:56 AM
to Slava Egorov, Alexander Thomas, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov
Martin Kustermann voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
5:24 AM (10 hours ago) 5:24 AM
to Martin Kustermann, Alexander Thomas, rev...@dartlang.org, vm-...@dartlang.org
Slava Egorov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
8:01 AM (8 hours ago) 8:01 AM
to Slava Egorov, Martin Kustermann, Alexander Thomas, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[stable] Fix Process::Exec stdio handle inheritance
Issue description: dart run crashes on Windows in GitBash or similar
terminals.
What is the fix: Fix Process::Exec to account for situations when
stdout and stderr are the same handles.
Why cherry-pick: Currently dart run is completely broken on certain
terminal emulators.
Risk: Low, landed on main and tested.
Issue link(s): https://github.com/dart-lang/sdk/issues/61981
TEST=vm/dart/regress_61981
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/464382
Change-Id: I357725f8982814c02f28267a8629ce5099fe4b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465560
Reviewed-by: Alexander Thomas <at...@google.com>
Commit-Queue: Slava Egorov <veg...@google.com>
Reviewed-by: Martin Kustermann <kuste...@google.com>
Files:
- M BUILD.gn
- M CHANGELOG.md
- M runtime/bin/BUILD.gn
- A runtime/bin/create_process_test_helper.cc
- M runtime/bin/process.cc
- M runtime/bin/process_win.cc
- M runtime/bin/utils_win.cc
- A runtime/tests/vm/dart/regress_61981_test.dart
Change size: L
Delta: 8 files changed, 241 insertions(+), 24 deletions(-)
Branch: refs/heads/stable
Submit Requirements:
Cherry-Pick-Review: Code-Review+1 by Martin Kustermann, Code-Review+1 by Alexander Thomas
Code-Review: +1 by Martin Kustermann, +1 by Alexander Thomas
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages